-
Notifications
You must be signed in to change notification settings - Fork 0
Parameterize docker-compose, centralize CORS, and replace secrets with placeholders for local/AWS readiness #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Deathbot545
merged 1 commit into
master
from
codex/optimize-and-prepare-docker-compose-for-aws
Feb 1, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| POSTGRES_USER=postgres | ||
| POSTGRES_PASSWORD=postgres | ||
|
|
||
| APPLICATION_DB_CONNECTION=Host=postgres;Port=5432;Database=ApplicationDb;Username=postgres;Password=postgres | ||
| OUTLET_DB_CONNECTION=Host=postgres;Port=5432;Database=OutletDb;Username=postgres;Password=postgres | ||
| MENU_DB_CONNECTION=Host=postgres;Port=5432;Database=MenuDb;Username=postgres;Password=postgres | ||
|
|
||
| MONGO_CONNECTION_STRING=mongodb://mongo:27017 | ||
| MONGO_DATABASE=FoodOrdering | ||
|
|
||
| JWT_KEY=dev-super-secret-key | ||
| JWT_ISSUER=dev | ||
| JWT_AUDIENCE=dev | ||
|
|
||
| FOOD_ORDERING_API_BASE_URL=http://food-ordering-api/ | ||
| RESTAURANT_API_BASE_URL=http://restaurant-api/ | ||
|
|
||
| ALLOWED_ORIGINS=http://localhost:8088,http://localhost:8089 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Local defaults - copy to .env and tweak for production/AWS | ||
| POSTGRES_USER=postgres | ||
| POSTGRES_PASSWORD=postgres | ||
|
|
||
| APPLICATION_DB_CONNECTION=Host=postgres;Port=5432;Database=ApplicationDb;Username=postgres;Password=postgres | ||
| OUTLET_DB_CONNECTION=Host=postgres;Port=5432;Database=OutletDb;Username=postgres;Password=postgres | ||
| MENU_DB_CONNECTION=Host=postgres;Port=5432;Database=MenuDb;Username=postgres;Password=postgres | ||
|
|
||
| MONGO_CONNECTION_STRING=mongodb://mongo:27017 | ||
| MONGO_DATABASE=FoodOrdering | ||
|
|
||
| JWT_KEY=dev-super-secret-key | ||
| JWT_ISSUER=dev | ||
| JWT_AUDIENCE=dev | ||
|
|
||
| FOOD_ORDERING_API_BASE_URL=http://food-ordering-api/ | ||
| RESTAURANT_API_BASE_URL=http://restaurant-api/ | ||
|
|
||
| # Comma-separated list of allowed origins for APIs and Kitchen_Web | ||
| ALLOWED_ORIGINS=http://localhost:8088,http://localhost:8089 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
Cors:AllowedOriginsis set via env (as indocker-compose.yml/.envwith a comma-separated list),Get<string[]>()binds it as a single-element array containing the entire string (e.g.,"http://localhost:8088,http://localhost:8089"). Because the code returns early onLength > 0, the comma-split fallback never runs, andWithOrigins(...)receives an invalid origin containing a comma, which throws at startup in the default docker-compose configuration. Consider checking for a single entry that contains commas and splitting before returning, or prefer the raw string split when the value comes from env.Useful? React with 👍 / 👎.