refactor: extract testFilterArgs helper for consistent test filter handling#5
Merged
Merged
Conversation
…ndling Centralizes test filter argument construction into a single `testFilterArgs()` function in `src/core/bazel.ts`, replacing duplicated inline logic across 5 handler/streaming files. Adds support for pipe-separated values (e.g. "SuiteA |SuiteB") which are converted to comma-separated format for rules_apple compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
maatheusgois-dd
marked this pull request as ready for review
May 20, 2026 23:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--test_filterargument construction into a centralizedtestFilterArgs()helper insrc/core/bazel.ts"SuiteA |SuiteB") which are converted to comma-separated format forrules_applecompatibilitybuild.ts,device.ts,macos.ts,multi-platform.ts,streaming.ts) with the shared helperScope
Validation
npm run lintnpm run typechecknpm testCompatibility
Notes For Reviewers
The
testFilterArgsfunction handles three cases:[]["--test_filter=value"]|, trims, joins with,→ returns["--test_filter=A,B,C"]All 434 tests pass, including 4 new unit tests for the helper.
Made with Cursor