feat: add support for all players page switch#301
Open
titivermeesch wants to merge 1 commit intoDecentSoftware-eu:mainfrom
Open
feat: add support for all players page switch#301titivermeesch wants to merge 1 commit intoDecentSoftware-eu:mainfrom
titivermeesch wants to merge 1 commit intoDecentSoftware-eu:mainfrom
Conversation
Author
|
I also noticed I did a manual version bump, let me know if that should be removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature request
One of the users of a plugin of mine wanted to allow switching pages of a hologram for everyone, but this does not seem possible right now, only per player.
This feature adds the option to use
*instead of a player name to switch the pages for everyone.Considerations
I'm not familiar with the codebase, if there is a better way to do this please enlighten me.