Optimize map operations by removing redundant containsKey checks#380
Open
OverwriteMC wants to merge 3 commits intoDecentSoftware-eu:mainfrom
Open
Optimize map operations by removing redundant containsKey checks#380OverwriteMC wants to merge 3 commits intoDecentSoftware-eu:mainfrom
OverwriteMC wants to merge 3 commits intoDecentSoftware-eu:mainfrom
Conversation
to avoid double map operations
To optimize this check
get method returns the object we need, and if it's not in the map, it returns null. containsKey, on the other hand, performs the same operations as get but doesn't return anything сhecking for null is faster than performing double operations, so it's efficient to avoid calling containsKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: We don't need to do the same action multiple times.
containsKeyandgetgenerally perform identical checks, so by combining thegetmethod with a null check, we avoid unnecessary CPU and RAM usage with thecontainsKeymethod