Folia support via reflection and PaperLib (#188)#382
Open
Jsinco wants to merge 6 commits intoDecentSoftware-eu:mainfrom
Open
Folia support via reflection and PaperLib (#188)#382Jsinco wants to merge 6 commits intoDecentSoftware-eu:mainfrom
Jsinco wants to merge 6 commits intoDecentSoftware-eu:mainfrom
Conversation
…ograms # Conflicts: # plugin/src/main/java/eu/decentsoftware/holograms/api/DecentHolograms.java # plugin/src/main/java/eu/decentsoftware/holograms/api/listeners/PlayerListener.java # plugin/src/main/java/eu/decentsoftware/holograms/api/utils/scheduler/S.java # plugin/src/main/java/eu/decentsoftware/holograms/api/utils/scheduler/SchedulerAdapter.java # plugin/src/main/java/eu/decentsoftware/holograms/api/utils/scheduler/adapters/BukkitSchedulerAdapter.java # plugin/src/main/java/eu/decentsoftware/holograms/api/utils/scheduler/adapters/FoliaSchedulerAdapter.java # src/main/java/eu/decentsoftware/holograms/api/utils/tick/Ticker.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an updated version of #188. HarvelsX's Folia implementation works well, although it should be tested more thoroughly. I'm making this PR so that Folia support gets more attention and so we can get a merge at some point.
HavelsX's PR is outdated by over two years at this point so I've skipped straight to opening a new PR on this repo based on their changes.
In addition to merging #188's changes into the latest commits of DecentHolograms, I've also fixed an issue where this plugin was making
Entity#teleportcalls (folia does not support this and instead requiresEntity#teleportAsync). I have done this by using PaperLib so that Paper servers can also reap the benefits ofEntity#teleportAsyncbut this can be changed to a reflective call if need be.This PR closes #123 and supersedes #188.
For any non-developers reading this PR, I will be merging commits from DecentHolograms into this fork and releasing them as compiled jars for anyone to use and test. If you encounter any issues please make an issue on my fork so I can fix it.