Make it run on 26.1#388
Open
gaboss44 wants to merge 2 commits intoDecentSoftware-eu:mainfrom
Open
Conversation
Contributor
|
Looks good. Also update item-nbt-api to 2.15.7 to support 26.1 [23:01:01] [Server thread/WARN]: [NBTAPI] [NBTAPI] This Server-Version(26.1.1-R0.1-SNAPSHOT) is not supported by this NBT-API Version(2.15.5) located in DecentHolograms. The NBT-API will try to work as good as it can! Some functions may not work!
[23:01:01] [Server thread/WARN]: [DecentHolograms] NBT-API could not be loaded. Custom NBT in items may not work as expected. |
Contributor
|
26.1.2 is failing. The version check should ignore the patch version. [23:11:34 INFO]: [DecentHolograms] Enabling DecentHolograms v2.9.10
[23:11:34 ERROR]: [DecentHolograms] Unsupported server version detected: 26.1.2-DEV-8987f91 (MC: 26.1.2)
[23:11:34 ERROR]: [DecentHolograms] Plugin will now be disabled.
[23:11:34 INFO]: [DecentHolograms] Disabling DecentHolograms v2.9.10 |
|
DecentHolograms-2.9.10.jar.zip PR for testing using PR for xseries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now runs on 26.1 (I've tested it in Paper 26.1.1.build.29-alpha).
Changes:
sendis used instead ofsendPacketin nms/nms-v26_1/src/main/java/eu/decentsoftware/holograms/nms/v26_1/EntityPacketsBuilder.javagetKeyis used instead ofgetKeyOrThrowin nms/nms-v26_1/src/main/java/eu/decentsoftware/holograms/nms/v26_1/EntityTypeRegistry.javaVersion#getCurrentMinecraftVersionwas modified to correctly detect version 26.1 and later (hopefully this won't affect earlier versions).