This repository was archived by the owner on Jul 21, 2024. It is now read-only.
Conversation
Member
Author
|
안쓰는 DTO 제거 완료 |
98StarJune
suggested changes
Sep 27, 2023
| } | ||
|
|
||
| [HttpGet] | ||
| public async Task<ActionResult> ChatLog(long roomId) |
Member
There was a problem hiding this comment.
보안을 위한 작업이 추가로 필요할 것 같습니다.
만약에 RoomID가 탈취 되었을 경우 해당 채팅 방에서의 모든 채팅 기록을 받아볼 수 있을 가능성이 있어보입니다.
여러 방법이 있겠지만 JWT 인증을 통해 payload의 UserID(고유값)을 취하고 이를 Room 내 속해있는 유저인지 확인하는 작업이 추가되면 이를 개선할 수 있지 않을까 하는 제안을 해봅니다.
Member
Author
There was a problem hiding this comment.
추석때 쉬라매!!!!!!!!!!!!!!!!!
server/DTOs/chat/ChatLogRequest.cs
Outdated
| @@ -0,0 +1,9 @@ | |||
| // 추후에 개발하다가 안쓰는게 확실해지면 지울 예정입니다. | |||
Member
There was a problem hiding this comment.
사용하지 않은 클래스는 제거 해주세요.......!
Member
Author
|
일단 id 확인하는거 추가는 했는데 테스트 어케해여? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
Chat Log를 반환해주는 코드 작성
세부 내용
ChatLog가 없는 경우 404 Not Found 반환
ChatLog가 있는 경우 200, ChatLog List 반환
Test를 위해 인증 제거 후 Test