Conversation
Deep1998
force-pushed
the
acc1
branch
2 times, most recently
from
2a27864 to
38d4567
Compare
aksharauke
reviewed
Jan 16, 2024
aksharauke
approved these changes
Jan 23, 2024
Deep1998
force-pushed
the
acc2
branch
3 times, most recently
from
b6c6ab3 to
0e296a7
Compare
* Add dataflow accessor * Add enable streaming engine struct tag Mofe Unmarshall Method to acc2 due ot storage dependency * Moved dataflow utils to accessor and creates types.go * Create dataflowutils package * Renamed testing package for dataflow util * Added unit tests * Added empty test files for clients * Move test to same package * Add tests for dataflow client * Update fake for client test * Make dataflow accessor interface and struct to make it testable * Remove interface from accessor package * Add dataflow accessor interface * Add comments to dataflow client and comments on unit tests * Move all dataflow dependencies to accessors and remove dataflow utils * Create dataflow client interface for accessor method to make it unit testable
Add log statements to storage accessor functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accessors similar to dataflow for spanner and storage. All calls to the client should go via the accessor.
We still have util files that contain methods that do not call the client. In this PR, this is the storage_client.go