fix(fib): add type annotations and strict equality for ESLint compliance#3
Merged
DeepakReddyG merged 1 commit intomainfrom Aug 24, 2025
Merged
fix(fib): add type annotations and strict equality for ESLint compliance#3DeepakReddyG merged 1 commit intomainfrom
DeepakReddyG merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
n: numberand: numbertype annotations to thefibonaccifunction infib.tsto fix ESLint errors (@typescript-eslint/no-unsafe-return,@typescript-eslint/restrict-plus-operands).==to===for strict equality checks.Testing
npm run lintin the terminal to check for ESLint errors infib.ts—no errors showed up.fibonaccifunction withfibonacci(5)(got 8),fibonacci(0)(got 0), andfibonacci(-1)(got -1) to make sure it works.fibRoute.tsstill works with the updatedfib.tsby testingGET /5in my app (it returnedfibonacci(5) is 8).Fixes #1