Add Boar Finance APY adapter#2766
Open
kpyszkowski wants to merge 3 commits into
Open
Conversation
|
Error while running boar-finance adapter: Test Suites: 1 failed, 1 total |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds Boar Finance BTC Vault Adapter
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The boar-finance adapter exports pools: Test Suites: 1 passed, 1 total |
Author
|
@RohanNero tagging you since you are in the loop merging DefiLlama/DefiLlama-Adapters#19794 some time ago |
0xkr3p
reviewed
Jul 9, 2026
| chain: utils.formatChain(CHAIN), | ||
| project: "boar-finance", | ||
| symbol: "BTC", | ||
| poolMeta: "veBTC — Boar managed", |
Contributor
There was a problem hiding this comment.
pls rename to 28d unstake lock
0xkr3p
reviewed
Jul 9, 2026
| // Step 5: mirrors computeEpochApy + weeklyRateToApy | ||
| const rateBP = (yieldAmount * APY_PRECISION) / lockedAmount; | ||
| const rate = Number(rateBP) / Number(APY_PRECISION); | ||
| const apyBase = ((1 + rate) ** EPOCHS_PER_YEAR - 1) * 100; |
Contributor
There was a problem hiding this comment.
Just dbl checking this apy is net?
0xkr3p
reviewed
Jul 9, 2026
| tvlUsd, | ||
| apyBase, | ||
| underlyingTokens: [BTC], | ||
| rewardTokens: [BTC], |
Contributor
There was a problem hiding this comment.
reward tokens can be removed
0xkr3p
reviewed
Jul 9, 2026
0xkr3p
left a comment
0xkr3p
left a comment
Contributor
There was a problem hiding this comment.
hi @kpyszkowski, thanks for the PR. A few things to resolve before we can merge. I've left some comments on the PR. Can you also take a look at using the lookup block from the sdk instead of hardcoding estimations. Here is some code which could help:
The lines involved:
- 57–59 — hardcoded constants MAINNET_DEPLOYMENT_BLOCK, MAINNET_DEPLOYMENT_TIMESTAMP,
MAINNET_AVG_BLOCK_TIME
- 88–91 — the estimateBlockAtEpochStart() function
- 114 — const epochStartBlock = estimateBlockAtEpochStart(epochStart);
- 117–132 — the Promise.all (only reads locked at the epoch-start block)
- 145 — const tvlUsd = (Number(lockedAmount) / 1e18) * btcPrice; ← uses the epoch-start amount for
TVL
Change 1 — line 114 (block from API, not estimate):
// before
const epochStartBlock = estimateBlockAtEpochStart(epochStart);
// after
const { block: epochStartBlock } = await sdk.api.util.lookupBlock(epochStart, { chain: CHAIN });
…then delete the now-unused estimateBlockAtEpochStart (88–91) and the three constants (57–59).
Change 2 — TVL from current locked, not epoch-start. Add a second (latest-block) locked read to
the Promise.all (117–132) and use it only for TVL; keep the epoch-start read purely as the APY
denominator:
const [lockedRes, currentLockedRes, yieldRes, priceData] = await Promise.all([
sdk.api.abi.call({ target: VE_BTC, abi: LOCKED_ABI, params: [MANAGED_TOKEN_ID], chain: CHAIN,
block: epochStartBlock }), // epoch-start → APY denominator
sdk.api.abi.call({ target: VE_BTC, abi: LOCKED_ABI, params: [MANAGED_TOKEN_ID], chain: CHAIN }),
// current → TVL
sdk.api.abi.call({ target: BOAR_BTC_RELAY, abi: YIELD_PER_EPOCH_ABI, params: [epochStart],
chain: CHAIN }),
utils.getPrices([BTC], CHAIN),
]);
Then at line 145:
// before
const tvlUsd = (Number(lockedAmount) / 1e18) * btcPrice;
// after
const currentLocked = BigInt((currentLockedRes.output as LockedTuple).amount);
const tvlUsd = (Number(currentLocked) / 1e18) * btcPrice;
(lockedAmount at line 134 stays as-is — it's the correct epoch-start denominator for the rate at
line 140.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new yield adapter for Boar Finance's BTC vault on Mezo. The adapter closely mirrors the dapp's APY calculation logic, fetching recent compound events from a subgraph, estimating the relevant block, and reading on-chain data to compute the APY and TVL for the vault.
New Boar Finance BTC vault adapter:
src/adaptors/boar-finance/index.jsthat replicates the dapp's APY calculation for the BTC vault on Mezo, including subgraph queries and on-chain reads.timetravel: falseand provides the Boar Finance dashboard URL.Summary by CodeRabbit