Conversation
JackDoan
reviewed
Feb 20, 2026
android/app/src/main/kotlin/net/defined/mobile_nebula/NebulaVpnService.kt
Show resolved
Hide resolved
JackDoan
reviewed
Feb 20, 2026
nebula/site.go
Outdated
| CASha *string `json:"caSha"` | ||
| } | ||
|
|
||
| func fromConfigFirewallRule(r configFirewallRule) firewallRule { |
Contributor
There was a problem hiding this comment.
this is so so so close to the real rule parser it would be nice to uhhh not have this
JackDoan
reviewed
Feb 20, 2026
nebula/site.go
Outdated
|
|
||
| port := strings.TrimSpace(r.Port) | ||
| switch { | ||
| case port == "" || strings.ToLower(port) == "any": |
Contributor
There was a problem hiding this comment.
no code support smh my head
JackDoan
reviewed
Feb 20, 2026
nebula/site.go
Outdated
| h := r.Host | ||
| rule.Host = &h | ||
| } | ||
| if r.Group != "" { |
Contributor
There was a problem hiding this comment.
group and groups is illegal in nebula but not here
JackDoan
reviewed
Feb 20, 2026
JackDoan
reviewed
Feb 20, 2026
| this.errors = errors ?? []; | ||
| this.unsafeRoutes = unsafeRoutes ?? []; | ||
| this.dnsResolvers = dnsResolvers ?? []; | ||
| this.inboundRules = inboundRules ?? []; |
Contributor
There was a problem hiding this comment.
we don't have a default-icmp-allow-inbound today right?
Contributor
There was a problem hiding this comment.
do we wanna add something to fall back to these if the configured rules aren't null but parse fails?
…should just use material widgets since platform widgets has been EOLd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: CRUD and yaml import support for firewall rules