Remove IncomingSite, muck with config less in the intermediate layers#361
Merged
Remove IncomingSite, muck with config less in the intermediate layers#361
Conversation
nbrownus
force-pushed
the
worktree-site-simplification
branch
from
37c0691 to
52a467e
Compare
JackDoan
reviewed
Mar 4, 2026
JackDoan
reviewed
Mar 4, 2026
nbrownus
force-pushed
the
worktree-site-simplification
branch
4 times, most recently
from
4ec4a6c to
9f23c65
Compare
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
reviewed
Mar 5, 2026
JackDoan
previously approved these changes
Mar 5, 2026
Remove jsonTrue type that always marshaled to true, change site.Managed to plain bool. This fixes a bug where unmanaged sites were incorrectly becoming managed during v0→v1 migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Native save functions (saveSiteToDisk in Swift, saveSite in Kotlin) now stamp configVersion = 1 on write. Dart default changed from 1 to 0 since native always overrides it on save. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Go tests (nebula/mobileNebula_test.go): - TestMigrateConfig: verify unmanaged v0 site stays unmanaged (the bug fix) - TestMigrateConfig_ManagedSite: verify managed v0 site stays managed - TestMigrateConfig_ConfigVersion: verify migrated config has configVersion 1 - TestMigrateConfig_KeyStripped: verify pki.key removed from rawConfig - TestMigrateConfig_ManagedWithRawConfig: test migration of managed site with existing YAML rawConfig from old DN-enrolled flow Dart tests (test/models/site_test.dart): - configVersion defaults to 0 for new sites (native stamps 1 on save) - configVersion round-trips through toJson - fromYaml produces default configVersion 0 - managed flag defaults and serialization - Fix existing test expecting configVersion 1 (now 0) CI: Add .github/workflows/gotest.yml to run Go tests on PRs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nbrownus
force-pushed
the
worktree-site-simplification
branch
from
62dd998 to
c3cd4d0
Compare
JackDoan
previously approved these changes
Mar 5, 2026
nbrownus
force-pushed
the
worktree-site-simplification
branch
from
c780448 to
e399492
Compare
JackDoan
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative approach to #358 for config shenanigans
This adds support for full yaml import.