Surface report producer context safely #31
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,6 +68,51 @@ describe("TrackReportPage", () => { | |
| expect(markup).toContain("recon_artifact_mainline"); | ||
| }); | ||
|
|
||
| it("hydrates sanitized producer context from the completed job detail facade", async () => { | ||
| vi.stubGlobal("fetch", vi.fn(async (input: RequestInfo | URL) => { | ||
| const url = String(input); | ||
| if (url.includes("/api/v1/audit/jobs/job_demo_004")) { | ||
| return Response.json({ | ||
| job: { | ||
| status: "completed", | ||
| updated_at: "2026-05-15T08:12:30Z", | ||
| stdout_tail: "saved C:\\runtime\\private\\score.json\nreported token=abc123", | ||
| stderr_tail: "upload to http://localhost:8780 failed", | ||
| state_history: [ | ||
| { state: "queued", timestamp: "2026-05-15T08:12:00Z" }, | ||
| { state: "completed", timestamp: "2026-05-15T08:12:30Z" }, | ||
| ], | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| return new Response(null, { status: 404 }); | ||
| })); | ||
|
|
||
| const markup = renderToStaticMarkup( | ||
| await renderTrackReportPage({ | ||
| locale: "en-US", | ||
| params: { track: "black-box" }, | ||
| searchParams: { | ||
| view: "audit", | ||
| job: "job_demo_004", | ||
| contract: "recon_artifact_mainline", | ||
| model: "stable-diffusion-v1-4", | ||
| auc: "0.849", | ||
| }, | ||
| }), | ||
| ); | ||
|
|
||
| expect(markup).toContain("Producer context"); | ||
| expect(markup).toContain("Runtime output tail"); | ||
| expect(markup).toContain("<local-path>"); | ||
| expect(markup).toContain("token=<redacted>"); | ||
| expect(markup).toContain("<runtime-url>"); | ||
| expect(markup).not.toContain("C:\\runtime\\private"); | ||
| expect(markup).not.toContain("abc123"); | ||
| expect(markup).not.toContain("localhost:8780"); | ||
| }); | ||
|
|
||
| it("keeps completed job context safe when no snapshot row matches", async () => { | ||
| const markup = renderToStaticMarkup( | ||
| await renderTrackReportPage({ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,7 @@ import { type EvidenceSummaryPayload } from "@/lib/audit-client"; | |
| import { backendBaseUrl } from "@/lib/api-proxy"; | ||
| import { fetchWithTimeout } from "@/lib/fetch-timeout"; | ||
| import { resolveLocaleFromHeaderStore } from "@/lib/locale"; | ||
| import { ReportAuditView, type ReportProducerContext, type ReportProvenance } from "./ReportAuditView"; | ||
| import { ReportDisplayView } from "./ReportDisplayView"; | ||
|
|
||
| const DEFAULT_SERVER_FETCH_TIMEOUT_MS = 600; | ||
|
|
@@ -94,20 +93,14 @@ function pageTitle(locale: Locale, label: string) { | |
| return locale === "zh-CN" ? `${label}报告详情` : `${label} report details`; | ||
| } | ||
|
|
||
| function toggleLabel(locale: Locale, view: ViewMode) { | ||
| if (locale === "zh-CN") { | ||
| return view === "display" ? "展示视图" : "审计视图"; | ||
| } | ||
| return view === "display" ? "Display view" : "Audit view"; | ||
| } | ||
|
|
||
| function historyPlaceholder(locale: Locale) { | ||
| return locale === "zh-CN" | ||
| ? "该审计线路的历史对比功能将在后续版本接入，当前为占位区域。" | ||
| : "Historical comparison for this track will be available in a future release. This area is reserved."; | ||
|
|
@@ -204,6 +197,73 @@ function buildJobContext(searchParams?: TrackReportPageSearchParams) { | |
| }; | ||
| } | ||
|
|
||
| function readJobEnvelope(payload: unknown) { | ||
| if (!payload || typeof payload !== "object") { | ||
| return null; | ||
| } | ||
|
|
||
| const record = payload as Record<string, unknown>; | ||
| const job = record.job; | ||
| if (job && typeof job === "object") { | ||
| return job as Record<string, unknown>; | ||
| } | ||
| return record; | ||
| } | ||
|
|
||
| function readStateHistory(value: unknown): ReportProducerContext["stateHistory"] { | ||
| if (!Array.isArray(value)) { | ||
| return []; | ||
| } | ||
|
|
||
| return value.flatMap((entry) => { | ||
| if (!entry || typeof entry !== "object") { | ||
| return []; | ||
| } | ||
|
|
||
| const record = entry as Record<string, unknown>; | ||
| if (typeof record.state !== "string") { | ||
| return []; | ||
| } | ||
|
|
||
| return [{ | ||
| state: record.state, | ||
| timestamp: typeof record.timestamp === "string" ? record.timestamp : null, | ||
| }]; | ||
| }); | ||
| } | ||
|
|
||
| async function fetchProducerContext(jobContext: ReturnType<typeof buildJobContext>): Promise<ReportProducerContext | undefined> { | ||
| if (!jobContext?.jobId) { | ||
| return undefined; | ||
| } | ||
|
|
||
| try { | ||
| const response = await fetchWithTimeout( | ||
| new URL(`/api/v1/audit/jobs/${encodeURIComponent(jobContext.jobId)}`, backendBaseUrl()), | ||
| { cache: "no-store" }, | ||
| { timeoutMs: DEFAULT_SERVER_FETCH_TIMEOUT_MS }, | ||
| ); | ||
| if (!response.ok) { | ||
| return undefined; | ||
| } | ||
|
|
||
| const job = readJobEnvelope(await response.json()); | ||
| if (!job) { | ||
| return undefined; | ||
| } | ||
|
|
||
| return { | ||
| status: typeof job.status === "string" ? job.status : null, | ||
| updatedAt: typeof job.updated_at === "string" ? job.updated_at : null, | ||
| stdoutTail: typeof job.stdout_tail === "string" ? job.stdout_tail : null, | ||
| stderrTail: typeof job.stderr_tail === "string" ? job.stderr_tail : null, | ||
| stateHistory: readStateHistory(job.state_history), | ||
| }; | ||
| } catch { | ||
| return undefined; | ||
| } | ||
| } | ||
|
|
||
| function findHighlightedRows(rows: AttackDefenseRowViewModel[], jobContext: ReturnType<typeof buildJobContext>) { | ||
| if (!jobContext) { | ||
| return []; | ||
|
|
@@ -243,9 +303,11 @@ export async function renderTrackReportPage({ | |
| const rows = filterRows(table?.rows ?? [], track); | ||
| const highlightedRowKeys = findHighlightedRows(rows, jobContext); | ||
| const catalogEntries = catalog?.tracks.find((item) => item.track === track)?.entries ?? []; | ||
| const [provenance, producerContext] = await Promise.all([ | ||
| fetchTrackProvenance(pickPrimaryEntry(catalogEntries)), | ||
| fetchProducerContext(jobContext), | ||
| ]); | ||
| const label = trackLabel(resolvedLocale, track); | ||
| const displayHref = `/workspace/reports/${track}?view=display`; | ||
| const auditHref = `/workspace/reports/${track}?view=audit`; | ||
|
|
||
|
|
@@ -290,8 +352,9 @@ export async function renderTrackReportPage({ | |
| locale={resolvedLocale} | ||
| rows={rows} | ||
| provenance={provenance} | ||
| historyPlaceholder={historyPlaceholder(resolvedLocale)} | ||
| jobContext={jobContext} | ||
| producerContext={producerContext} | ||
| highlightedRowKeys={highlightedRowKeys} | ||
| /> | ||
| ) : ( | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback string
"Unknown"used for state history entries is hardcoded. It should be localized within thettranslation object to maintain consistency with the rest of the UI.