Skip to content

QA fixes before release #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ussaama merged 2 commits into from
Mar 10, 2026
Merged

QA fixes before release #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7418864
QA fixes before release
ussaama Mar 10, 2026
1206080
missing translations fix
ussaama Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions echo/frontend/src/components/participant/hooks/useOnboardingCards.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions echo/frontend/src/components/settings/LegalBasisSettingsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ export const LegalBasisSettingsCard = () => {
<Text size="sm" c="dimmed">
<Trans>
Determines under which GDPR legal basis personal data is processed.
This affects consent flows, data subject rights, and retention
obligations.
This affects the information shown to participants and data subject
rights.
</Trans>
</Text>

Expand Down
8 changes: 6 additions & 2 deletions echo/frontend/src/locales/de-DE.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,8 +1441,12 @@ msgid "Describe what the language model should extract or summarize from the con
msgstr "Beschreiben Sie, was die Sprachmodell aus dem Gespräch extrahieren oder zusammenfassen soll..."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
msgstr "Bestimmt, unter welcher GDPR-Rechtsgrundlage personenbezogene Daten verarbeitet werden. Dies beeinflusst die Einwilligungsflüsse, die Rechte der Betroffenen und die Aufbewahrungspflichten."
#~ msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgstr "Bestimmt, unter welcher GDPR-Rechtsgrundlage personenbezogene Daten verarbeitet werden. Dies beeinflusst die Einwilligungsflüsse, die Rechte der Betroffenen und die Aufbewahrungspflichten."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."
msgstr "Bestimmt, unter welcher GDPR-Rechtsgrundlage personenbezogene Daten verarbeitet werden. Dies beeinflusst die Informationen, die an Teilnehmer und betroffene Personen gezeigt werden und deren Rechte."

#: src/components/project/ProjectPortalEditor.tsx:709
msgid "Determines under which GDPR legal basis personal data is processed. This setting applies to all your projects and can be changed in your account settings."
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/de-DE.ts
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions echo/frontend/src/locales/en-US.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,8 +1666,12 @@ msgstr "Describe what the language model should extract or summarize from the co
#~ msgstr "Description"

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
msgstr "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgstr "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."
msgstr "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."

#: src/components/project/ProjectPortalEditor.tsx:709
msgid "Determines under which GDPR legal basis personal data is processed. This setting applies to all your projects and can be changed in your account settings."
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/en-US.ts
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions echo/frontend/src/locales/es-ES.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,8 +1444,12 @@ msgid "Describe what the language model should extract or summarize from the con
msgstr "Describe lo que el modelo de lenguaje debe extraer o resumir de la conversación..."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
msgstr "Determina bajo qué base legal de GDPR se procesan los datos personales. Esto afecta a los flujos de consentimiento, los derechos de los sujetos de datos y las obligaciones de retención."
#~ msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgstr "Determina bajo qué base legal de GDPR se procesan los datos personales. Esto afecta a los flujos de consentimiento, los derechos de los sujetos de datos y las obligaciones de retención."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."
msgstr "Determina bajo qué base legal de GDPR se procesan los datos personales. Esto afecta a la información que se muestra a los participantes y a los derechos de los sujetos de datos."

#: src/components/project/ProjectPortalEditor.tsx:709
msgid "Determines under which GDPR legal basis personal data is processed. This setting applies to all your projects and can be changed in your account settings."
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/es-ES.ts
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions echo/frontend/src/locales/fr-FR.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,8 +1459,12 @@ msgid "Describe what the language model should extract or summarize from the con
msgstr "Décrivez ce que le modèle de langage doit extraire ou résumer de la conversation..."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
msgstr "Détermine sous quelle base juridique de GDPR les données personnelles sont traitées. Cela affecte les flux de consentement, les droits des sujets des données et les obligations de conservation."
#~ msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgstr "Détermine sous quelle base juridique de GDPR les données personnelles sont traitées. Cela affecte les flux de consentement, les droits des sujets des données et les obligations de conservation."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."
msgstr "Détermine sous quelle base juridique de GDPR les données personnelles sont traitées. Cette configuration s'applique à tous vos projets et peut être modifiée dans vos paramètres de compte."
Comment on lines +1465 to +1467
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Translation mismatch detected – French text doesn't match English source.

The French translation at line 1467 describes project settings configuration, but the English source at line 1466 talks about "information shown to participants and data subject rights." Looks like the French was copied from line 1470's msgid instead.

🔧 Proposed fix 
 #: src/components/settings/LegalBasisSettingsCard.tsx:87
 msgid "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."
-msgstr "Détermine sous quelle base juridique de GDPR les données personnelles sont traitées. Cette configuration s'applique à tous vos projets et peut être modifiée dans vos paramètres de compte."
+msgstr "Détermine sous quelle base juridique de GDPR les données personnelles sont traitées. Cela affecte les informations affichées aux participants et les droits des sujets de données."
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@echo/frontend/src/locales/fr-FR.po` around lines 1465 - 1467, The French
translation for the msgid used in LegalBasisSettingsCard
(src/components/settings/LegalBasisSettingsCard.tsx:87) is incorrect — replace
the current msgstr (which refers to account/project settings) with a correct
French rendering of "Determines under which GDPR legal basis personal data is
processed. This affects the information shown to participants and data subject
rights." Update the msgstr in echo/frontend/src/locales/fr-FR.po so it
accurately mirrors the English source (mentioning information shown to
participants and data subject rights) and keep punctuation and capitalization
consistent with other entries.


#: src/components/project/ProjectPortalEditor.tsx:709
msgid "Determines under which GDPR legal basis personal data is processed. This setting applies to all your projects and can be changed in your account settings."
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/fr-FR.ts
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions echo/frontend/src/locales/it-IT.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,8 +1666,12 @@ msgstr "Describe what the language model should extract or summarize from the co
#~ msgstr "Description"

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
msgstr "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgstr "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."
msgstr "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."

#: src/components/project/ProjectPortalEditor.tsx:709
msgid "Determines under which GDPR legal basis personal data is processed. This setting applies to all your projects and can be changed in your account settings."
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/it-IT.ts
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 8 additions & 4 deletions echo/frontend/src/locales/nl-NL.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ msgstr "Klik om alle {totalCount} gesprekken te zien"

#: src/components/settings/LegalBasisSettingsCard.tsx:112
msgid "Client-managed"
msgstr "Client-beheerd"
msgstr "Door client beheerd"

#: src/components/project/webhooks/WebhookSettingsCard.tsx:282
msgid "Clone from another project"
Expand Down Expand Up @@ -1186,7 +1186,7 @@ msgstr "Verbinding ongezond"

#: src/components/settings/LegalBasisSettingsCard.tsx:113
msgid "Consent"
msgstr "Consent"
msgstr "Toestemming"

#~ msgid "Contact sales"
#~ msgstr "Neem contact op met sales"
Expand Down Expand Up @@ -1510,8 +1510,12 @@ msgstr "Beschrijf wat de taalmodel moet extraheren of samenvatten uit het gespre
#~ msgstr "Beschrijving"

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
msgstr "Bepaalt onder welke GDPR-rechtsgrondslag personenbezogene gegevens worden verwerkt. Dit heeft invloed op toestemmingsstromen, rechten van betrokkenen en bewaarplichten."
#~ msgid "Determines under which GDPR legal basis personal data is processed. This affects consent flows, data subject rights, and retention obligations."
#~ msgstr "Bepaalt op welke AVG-grondslag persoonsgegevens worden verwerkt. Dit is van invloed op de informatie die aan deelnemers wordt getoond en de rechten van betrokkenen."

#: src/components/settings/LegalBasisSettingsCard.tsx:87
msgid "Determines under which GDPR legal basis personal data is processed. This affects the information shown to participants and data subject rights."
msgstr "Bepaalt op welke AVG-grondslag persoonsgegevens worden verwerkt. Dit is van invloed op de informatie die aan deelnemers wordt getoond en de rechten van betrokkenen."

#: src/components/project/ProjectPortalEditor.tsx:709
msgid "Determines under which GDPR legal basis personal data is processed. This setting applies to all your projects and can be changed in your account settings."
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/nl-NL.ts
View file
Open in desktop

Large diffs are not rendered by default.

Loading