Skip to content

ECHO-716 Remind users to verify before finishing conversation#479

Merged
spashii merged 5 commits intomainfrom
remind-users-to-verify
Mar 13, 2026
Merged

ECHO-716 Remind users to verify before finishing conversation#479
spashii merged 5 commits intomainfrom
remind-users-to-verify

Conversation

@ussaama
Copy link
Contributor

@ussaama ussaama commented Mar 13, 2026

Summary by CodeRabbit

  • New Features

    • Added optional "Verify on Finish" setting for projects to prompt users to verify before ending conversations
    • New verification reminder banner displays during conversations when verification is required
    • Multi-language support added for verification prompts (German, Spanish, French, Italian, Dutch)
  • Chores

    • Field ordering adjustments

ussaama added 5 commits March 13, 2026 15:31
…ion flow

- Integrated verification prompts in the StopRecordingConfirmationModal to remind users to verify outcomes before finishing.
- Added logic to conditionally display a verification banner in ParticipantConversationAudioContent based on recording time and project settings.
- Enhanced the ParticipantConversationAudio component to handle verification actions, including skipping verification and navigating to the verification page.
- Updated the ProjectPortalEditor to include a toggle for enabling verification prompts on finish, improving user guidance during the conversation process.

This update aims to streamline the verification process and enhance user experience by ensuring participants are prompted to verify outcomes before concluding their audio conversations.
- Incremented the sort values for the fields: anonymize_transcripts, conversation_title_prompt, enable_ai_title_and_tags, and selected_verification_key_list to maintain proper ordering in the project schema.
- This change ensures that the fields are displayed in the correct sequence, enhancing the organization and usability of the project settings.
- Updated the verification banner to be a clickable link that navigates to the verification page, enhancing user interaction.
- Adjusted the localization references for the verification required message across multiple languages, ensuring consistency in the user interface.
- Improved the styling of the verification banner for better visibility and user experience.
@linear
Copy link

linear bot commented Mar 13, 2026

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR implements a "verify on finish" feature that prompts users to verify conversation artifacts before completing a recording. It adds a new boolean project field, extends the recording UI with verification flows and banners, updates TypeScript definitions, and adds multi-language translations.

Changes

Cohort / File(s) Summary
Directus Field Metadata
echo/directus/sync/snapshot/fields/project/anonymize_transcripts.json, conversation_title_prompt.json, enable_ai_title_and_tags.json, selected_verification_key_list.json
Updated sort order values (33→34, 34→35, 35→36) to maintain field order.
Directus Field Metadata - New
echo/directus/sync/snapshot/fields/project/is_verify_on_finish_enabled.json
Introduced new boolean field with metadata for UI display, validation, and database schema mapping.
Frontend Recording/Verification Components
echo/frontend/src/components/participant/ParticipantConversationAudio.tsx, ParticipantConversationAudioContent.tsx
Added artefact-aware verification gating with conditional banners and modal handlers; computed shouldVerifyOnFinish and showVerificationBanner states tied to project settings, artefact approval, and recording duration thresholds.
Frontend Verification Modal
echo/frontend/src/components/participant/StopRecordingConfirmationModal.tsx
Implemented two-phase modal flow with verification reminder prompt; added showVerifyOnFinish prop and handleSkipVerification/handleVerify callbacks; extended UI with conditional verification state rendering.
Frontend Verification Components
echo/frontend/src/components/participant/verify/VerifiedArtefactItem.tsx, VerifyArtefact.tsx
Reordered UI elements and added cache invalidation post-verification to ensure data consistency.
Frontend Configuration
echo/frontend/src/components/project/ProjectPortalEditor.tsx
Added form field and Switch UI component for is_verify_on_finish_enabled with conditional disable logic tied to is_verify_enabled state.
Frontend Type Definitions
echo/frontend/src/lib/typesDirectus.d.ts, echo/frontend/src/routes/project/ProjectRoutes.tsx
Extended Project interface with optional is_verify_on_finish_enabled field; added field to project portal settings query.
Frontend Localization
echo/frontend/src/locales/de-DE.po, en-US.po, es-ES.po, fr-FR.po, it-IT.po, nl-NL.po
Added new translation keys for verification prompts (participant.modal.verify_prompt.*, participant.banner.verification_required) with corresponding translations; realigned line references across existing entries.
Backend Schema
echo/server/dembrane/api/participant.py
Added is_verify_on_finish_enabled: bool = False field to PublicProjectSchema.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~40 minutes

Possibly related PRs

  • Dembrane/echo#370 — Both PRs modify VerifyArtefact.tsx to enhance the artifact verification workflow with query cache management.
  • Dembrane/echo#390 — Both PRs extend ParticipantConversationAudio.tsx and related participant recording components with new verification-related state and callbacks.
  • Dembrane/echo#470 — Both PRs extend the project verification configuration in ProjectPortalEditor.tsx and typesDirectus.d.ts with new verification-related fields.

Suggested labels

Feature, improvement

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding reminder/verification flow before finishing conversations. It directly reflects the core functionality introduced across multiple components and settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remind-users-to-verify
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@spashii spashii added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit ddbfa7d Mar 13, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants