Update translation for 'Excluding {days}' to Hebrew#907
Closed
Dor-bl wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks! Note that the "{days}" string is actually meant to stay untranslated because the card generator code is doing a replacement of "{days}" with the localized string (for example, "יום ו', שבת"), so if it were to be changed to "{ימים}", the replacement would not work. While unfortunately I can't merge this, I'm happy to have you contribute in other ways in the future! github-readme-streak-stats/src/card.php Lines 97 to 99 in a15ea36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes a minor translation improvement to the Hebrew language file, refining the placeholder for days to use a more accurate term.
src/translations.php, the placeholder in the translation for "Excluding {days}" was changed from{days}to{ימים}for better clarity and localization.Type of change
How Has This Been Tested?
composer testChecklist:
Screenshots