Skip to content

Update translation for 'Excluding {days}' to Hebrew#907

Closed
Dor-bl wants to merge 1 commit into
DenverCoder1:mainfrom
Dor-bl:patch-1
Closed

Update translation for 'Excluding {days}' to Hebrew#907
Dor-bl wants to merge 1 commit into
DenverCoder1:mainfrom
Dor-bl:patch-1

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Jun 3, 2026

Copy link
Copy Markdown

Description

This pull request makes a minor translation improvement to the Hebrew language file, refining the placeholder for days to use a more accurate term.

  • Hebrew translation update:
    • In src/translations.php, the placeholder in the translation for "Excluding {days}" was changed from {days} to {ימים} for better clarity and localization.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1

Copy link
Copy Markdown
Owner

Thanks!

Note that the "{days}" string is actually meant to stay untranslated because the card generator code is doing a replacement of "{days}" with the localized string (for example, "יום ו', שבת"), so if it were to be changed to "{ימים}", the replacement would not work.

While unfortunately I can't merge this, I'm happy to have you contribute in other ways in the future!

$separator = $localeTranslations["comma_separator"] ?? ", ";
$daysCommaSeparated = implode($separator, translateDays($excludedDays, $localeCode));
return str_replace("{days}", $daysCommaSeparated, $localeTranslations["Excluding {days}"]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants