fix: read WHITELIST from $_ENV so it works on Vercel#912
Open
myl7 wants to merge 3 commits into
Open
Conversation
The vercel-php runtime exposes env vars via $_ENV/getenv() rather than $_SERVER, matching how TOKEN is already read. Fixes DenverCoder1#911.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix whitelist enforcement on Vercel deployments by changing how the WHITELIST environment variable is read so that configured usernames are actually restricted as intended (per #911).
Changes:
- Switch whitelist loading from
$_SERVER["WHITELIST"]to$_ENV["WHITELIST"]in the whitelist check. - Update PHPUnit tests to set/unset
WHITELISTvia$_ENVinstead of$_SERVER.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/whitelist.php |
Changes the whitelist source from $_SERVER to $_ENV when parsing WHITELIST. |
tests/StatsTest.php |
Updates whitelist-related tests to use $_ENV["WHITELIST"] when simulating the env var. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When loading whitelists, change from
$_SERVERto$_ENVso Vercel's env can be read.Fixes #911
Type of change
How Has This Been Tested?
composer testChecklist:
Screenshots