Backport: Support non-UTC timezones for metrics operations#6363
Merged
Conversation
Historically we implicitly assumed UTC (and configured our container images explicitly that way). But it turns out users want to customize the timezone used by the application, which makes the implicit assumptions fall apart, in particular WRT metrics and their partition maintenance. This change makes the UTC-ness of metrics operations explicit, which allows the application to be set to arbitrary timezones and still function as intended. Also addresses other code locations that implicitly relied on UTC and made that expectation explicit. Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | -2 |
🟢 Coverage 93.33% diff coverage · -0.10% coverage variation
Metric Results Coverage variation ✅ -0.10% coverage variation (-1.00%) Diff coverage ✅ 93.33% diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (92acd33) 41684 36103 86.61% Head commit (58e7b1e) 41695 (+11) 36072 (-31) 86.51% (-0.10%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#6363) 15 14 93.33% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support non-UTC timezones for metrics operations.
Historically we implicitly assumed UTC (and configured our container images explicitly that way). But it turns out users want to customize the timezone used by the application, which makes the implicit assumptions fall apart, in particular WRT metrics and their partition maintenance.
This change makes the UTC-ness of metrics operations explicit, which allows the application to be set to arbitrary timezones and still function as intended.
Also addresses other code locations that implicitly relied on UTC and made that expectation explicit.
Addressed Issue
Backports #6344
Fixes #6341
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/