Forward group_by parameter to DefectDojo, v5 version#6416
Merged
nscuro merged 4 commits intoJun 18, 2026
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · 0.00% coverage variation
Metric Results Coverage variation ✅ 0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (fb8940e) 42089 36519 86.77% Head commit (99255b6) 42098 (+9) 36526 (+7) 86.76% (0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#6416) 10 10 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
webdevred
changed the title
…erty Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
When set, forwards the value as group_by in the DefectDojo import-scan and reimport-scan multipart form requests, allowing findings to be grouped into Finding Groups on import. When not set, behavior is unchanged (backwards compatible). Closes DependencyTrack#6061 Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
…y, adapt group_by tests to v5 API Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
webdevred
force-pushed
the
send-groupby-to-defect-dojo-main
branch
from
691019f to
a9ce4fc
Compare
nscuro
added
enhancement
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DefectDojo's import-scan and reimport-scan endpoints accept a
group_byparameter that clusters findings into Finding Groups on import, but Dependency-Track never forwarded it. Operators who rely on Finding Groups for triage had to setgroup_byoutside of DT or give it up entirely.This adds a per-project property
defectdojo.groupBythat, when set, is sent asgroup_byin the multipart form body for both import and reimport requests. When not set, behavior is unchanged.This is the v5 companion to #6130, which makes the same change for
4.14.x. Adapted for theMultipartBodyPublisher-basedDefectDojoClientin theapiservermodule.Addressed Issue
Related to #6061. v5 companion to #6130 (same change targeting
4.14.x).Additional Details
The implementation follows the same pattern as
defectdojo.testTitle: a per-projectProjectPropertyis read inDefectDojoUploaderand forwarded as a form field viaMultipartBodyPublisher.addFormField. No new abstraction was introduced.The dead
.build()fix included in the v4 PR does not apply here. The v5DefectDojoClientusesMultipartBodyPublisherrather than Apache HttpClient'sMultipartEntityBuilder, so there is no equivalent dead call to remove.Checklist