Fix getTabFromRoute erroneously considering URL query params#1592
Merged
Conversation
Some views "persist" search parameters in the URL query, while simultaneously watching the URL for which tab to show. The latter erroneously considered URL query params, such that typing in a search field would cause `getTabFromRoute` to yield no existing tab, which then caused the view to "snap" back to the default tab. Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
added
defect
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
getTabFromRouteerroneously considering URL query params.Addressed Issue
Fixes #1591
Additional Details
Some views "persist" search parameters in the URL query, while simultaneously watching the URL for which tab to show. The latter erroneously considered URL query params, such that typing in a search field would cause
getTabFromRouteto yield no existing tab, which then caused the view to "snap" back to the default tab.Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly