Skip to content

Optionally allow JsonSchema 6.x#66

Merged
DerManoMann merged 1 commit intoDerManoMann:mainfrom
usox:allow-jsonschema6
Dec 23, 2025
Merged

Optionally allow JsonSchema 6.x#66
DerManoMann merged 1 commit intoDerManoMann:mainfrom
usox:allow-jsonschema6

Conversation

@usox
Copy link
Contributor

@usox usox commented Oct 16, 2025

This allows the installation of justinrainbow/json-schema ^6 and upgrades the OpenApiSchemaMismatchException to work with the modified error-item structure (see json-schema upgrading guide).

Also this performs some minor refactorings in the exception as well as it adds a set of tests for it.

@usox
Copy link
Contributor Author

usox commented Oct 16, 2025

The JsonSchema 6.x Upgrading guide: https://github.com/jsonrainbow/json-schema/blob/main/UPGRADE-6.0.md

Copy link
Owner

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good, thanks. Sorry for taking so long to respond, it slipped my radar.
I'll have another look next week - reviewing on my phone is not ideal...

@usox usox force-pushed the allow-jsonschema6 branch from 978c6c9 to 0025ca6 Compare December 19, 2025 09:14
@usox
Copy link
Contributor Author

usox commented Dec 19, 2025

Generally looking good, thanks. Sorry for taking so long to respond, it slipped my radar.

No problem. I forgot about it in the meantime too 😅

I'll have another look next week - reviewing on my phone is not ideal...

Allright. I just updated the var-names to match the codestyle.

btw: thanks for your work on the openapi-related repositories.

Copy link
Owner

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit, but looking good after that - thanks a lot.

@usox usox force-pushed the allow-jsonschema6 branch from 0025ca6 to f6989ca Compare December 22, 2025 07:01
This allows the installation of `justinrainbow/json-schema` ^6 and
upgrades  the `OpenApiSchemaMismatchException` to work with the modified
error-item structure (see json-schema upgrading guide).

Also this performs some minor refactorings in the exception as well as
it adds a set of tests for it.
Copy link
Owner

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @usox

@DerManoMann DerManoMann merged commit 08c7050 into DerManoMann:main Dec 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants