Optionally allow JsonSchema 6.x#66
Merged
DerManoMann merged 1 commit intoDerManoMann:mainfrom Dec 23, 2025
Merged
Conversation
Contributor
Author
|
The JsonSchema 6.x Upgrading guide: https://github.com/jsonrainbow/json-schema/blob/main/UPGRADE-6.0.md |
DerManoMann
requested changes
Dec 18, 2025
Owner
DerManoMann
left a comment
There was a problem hiding this comment.
Generally looking good, thanks. Sorry for taking so long to respond, it slipped my radar.
I'll have another look next week - reviewing on my phone is not ideal...
978c6c9 to
0025ca6
Compare
Contributor
Author
No problem. I forgot about it in the meantime too 😅
Allright. I just updated the var-names to match the codestyle. btw: thanks for your work on the openapi-related repositories. |
DerManoMann
requested changes
Dec 21, 2025
Owner
DerManoMann
left a comment
There was a problem hiding this comment.
Another nit, but looking good after that - thanks a lot.
0025ca6 to
f6989ca
Compare
This allows the installation of `justinrainbow/json-schema` ^6 and upgrades the `OpenApiSchemaMismatchException` to work with the modified error-item structure (see json-schema upgrading guide). Also this performs some minor refactorings in the exception as well as it adds a set of tests for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the installation of
justinrainbow/json-schema^6 and upgrades theOpenApiSchemaMismatchExceptionto work with the modified error-item structure (see json-schema upgrading guide).Also this performs some minor refactorings in the exception as well as it adds a set of tests for it.