fix information loss in undirected graph #283
Open
Ankush-Chander wants to merge 2 commits intoDerwenAI:mainfrom
Open
fix information loss in undirected graph #283Ankush-Chander wants to merge 2 commits intoDerwenAI:mainfrom
Ankush-Chander wants to merge 2 commits intoDerwenAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an undirected graph, when we add duplicate edges, the associated weight is overwritten instead of accumulated.
As per networkx documentation:
For a hypothetical example:
current code leads to(overwriting):
Desired behaviour(accumulation):
Thanks to @yamika-g for pointing it out here: