Fix/issue 545 auto import unbound files#1802
Open
joaoheusi wants to merge 3 commits into
Open
Conversation
DetachHead
reviewed
May 19, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
- Drop redundant isTracked check (implied by isUserCode) - Use getBoundSourceFileInfo instead of getParseResults to avoid the extra parse work; expose it on ProgramView - Remove duplicate manual test in favor of the fourslash one and switch remaining assertions to tExpect
DetachHead
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545
This makes auto-import completions bind tracked workspace files on demand when they have not yet been opened or analyzed. This way symbols from unopened workspace modules can still appear in completion results.
Tested:
autoImporter.test.ts