Skip to content

Use nixpkgs 25.11#219

Closed
fesplugas wants to merge 1 commit intoDeterminateSystems:mainfrom
fesplugas:use-nixpkgs-25-11
Closed

Use nixpkgs 25.11#219
fesplugas wants to merge 1 commit intoDeterminateSystems:mainfrom
fesplugas:use-nixpkgs-25-11

Conversation

@fesplugas
Copy link
Contributor

@fesplugas fesplugas commented Mar 8, 2026

Summary by CodeRabbit

  • Chores
    • Updated Nixpkgs version options in the initialization command to reflect version 25.11 as the latest stable release, replacing the previous 24.11 version.

@coderabbitai
Copy link

coderabbitai bot commented Mar 8, 2026

📝 Walkthrough

Walkthrough

The pull request updates Nixpkgs version references in the CLI initialization module from version 24.11 to 25.11, renaming the associated constant and updating the latest version indicator text accordingly.

Changes

Cohort / File(s) Summary
Nixpkgs Version Update
src/cli/cmd/init/mod.rs
Renamed constant NIXPKGS_24_11 to NIXPKGS_25_11, updated NIXPKGS_LATEST text to reflect 25.11 as the current latest stable version, and updated related match arm references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version hops forth, from twenty-four to twenty-five,
Constants renamed, the code stays alive,
Latest stable now shines with fresh delight,
Small changes made, the system feels right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: updating Nixpkgs from version 24.11 to 25.11.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/cli/cmd/init/mod.rs (1)

87-103: ⚠️ Potential issue | 🔴 Critical

Update the stale 24.11 match arm.

Line 100 still matches NIXPKGS_24_11, but that constant was removed. This now fails to compile, and the pinned stable branch still points at 0.2411.* instead of 0.2511.*.

Proposed fix
-                NIXPKGS_24_11 => {
-                    flakehub_url!(FLAKEHUB_WEB_ROOT, "f", "NixOS", "nixpkgs", "0.2411.*")
+                NIXPKGS_25_11 => {
+                    flakehub_url!(FLAKEHUB_WEB_ROOT, "f", "NixOS", "nixpkgs", "0.2511.*")
                 }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/cli/cmd/init/mod.rs` around lines 87 - 103, The match arm currently
references the removed constant NIXPKGS_24_11 and pins the stable branch to the
old "0.2411.*" string; update the match arm in the Prompt::select match to use
NIXPKGS_25_11 (the existing constant used in the options list) and change the
branch string from "0.2411.*" to "0.2511.*" inside the flakehub_url! call so the
match arm for the stable pin compiles and points to the correct 25.11 revision.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/cli/cmd/init/mod.rs`:
- Around line 87-103: The match arm currently references the removed constant
NIXPKGS_24_11 and pins the stable branch to the old "0.2411.*" string; update
the match arm in the Prompt::select match to use NIXPKGS_25_11 (the existing
constant used in the options list) and change the branch string from "0.2411.*"
to "0.2511.*" inside the flakehub_url! call so the match arm for the stable pin
compiles and points to the correct 25.11 revision.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c154d27d-d6ad-491e-874c-2cbea2534ff5

📥 Commits

Reviewing files that changed from the base of the PR and between 3767f81 and db4fc8f.

📒 Files selected for processing (1)
  • src/cli/cmd/init/mod.rs

@fesplugas fesplugas closed this Mar 13, 2026
@fesplugas fesplugas deleted the use-nixpkgs-25-11 branch March 13, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant