Conversation
Upstream commit 4a5d960 ("Remove dependent realisations") changed the serialization of 'builtOutputs' in build result log messages: the 'id' and 'dependentRealisations' fields are gone. Update the test regex accordingly. Assisted-by: Claude Fable 5 <noreply@anthropic.com>
The merge of upstream commit 141053f ("configurable HTTP retry with full-jitter backoff") reverted the canRetry condition to the old upstream logic, which refuses to retry a download once bytes have been streamed to the sink unless the server accepts byte ranges. This lost the behavior introduced in 6839d85: restarting from scratch and discarding already-received data. The discard machinery survived the merge but was unreachable. Relax the condition again so that streamed downloads can be retried whenever the response is uncompressed, resuming via a Range request if possible and restarting otherwise. Fixes the truncated-NAR part of tests/functional/binary-cache.sh. Assisted-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
WIP, not finished yet.
Context