Conversation
SIGQUIT is a user-initiated "quit with core dump" action (e.g. pressing Ctrl-\ at a terminal), not a crash, but crashpad includes it in its set of handled signals, so it got uploaded to Sentry as a fatal error. For example, we received crash reports of nix sitting in the blocking stdin read at the flake nixConfig trust prompt when the user pressed Ctrl-\. Fix this by resetting SIGQUIT to its default disposition in initNix(), which runs after sentry_init() has installed the crashpad handlers. We already did this on macOS; now it's done on all platforms. Assisted-by: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesSignal initialization
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
cole-h
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reset SIGQUIT to its default handler (overriding the Sentry handler). Since SIGQUIT is a user-initiated core dump, we don't want to report these to Sentry.
Context
Summary by CodeRabbit