Make portfolio demo actions safe#90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/appand/app/leads/[leadId]with clear demo-only messaging.Demo action audit
/app: navigation and simulator links remain active;Call nowremains a safetel:link;Mark contactedandMark bookedare disabled in portfolio demo mode./app/leads: list/filter/open-lead links only; no mutation controls found./app/leads/[leadId]:Call nowremains a safetel:link;Mark contacted,Mark booked, andMark lostare disabled in portfolio demo mode and the server action is guarded./app/conversations: conversation rows only link to lead detail; no mutation controls found./app/settings:Save settingsand the settings fieldset are disabled in portfolio demo mode; direct posts are guarded before database writes./app/call-flow: navigation andtel:test-call links only; no database mutation controls found./app/billing: Stripe checkout and portal actions are disabled in portfolio demo mode; direct API posts redirect with the demo-disabled message before touching Stripe.Validation
./node_modules/.bin/tsx --test tests/portfolio-demo-actions.test.tsnpm run typechecknpm run lintnpm run testnpm run build