Conversation
Contributor
|
Please correct the project and update this pull request by pushing a new commit. |
This comment was marked as outdated.
This comment was marked as outdated.
| let displayValue = dropDownBox.option('displayValue'); | ||
| const text = dropDownBox.option('text'); | ||
| const textValue = text?.length ? text : undefined; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment |
Contributor
There was a problem hiding this comment.
this comment is not needed to pass npm run lint on local PC, is it for CI?
Contributor
Author
There was a problem hiding this comment.
I see the TS error in IDE: TS7053: Element implicitly has an any type because expression of type 0 can't be used to index type {}.
I can avoid it by changing displayValue type to any: let displayValue: any = dropDownBox.option('displayValue');
- renamed the service file - changed the imports order - added useReducer for selection, focus and DDB value - moved utils functions to service
Contributor
|
Please correct the project and update this pull request by pushing a new commit. |
Contributor
|
Please correct the project and update this pull request by pushing a new commit. |
Contributor
|
Please correct the project and update this pull request by pushing a new commit. |
artem-kurchenko
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.