DataGrid: unskip demos tests #32175
Open
DataGrid: unskip demos tests #32175
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-shakhova
force-pushed
the
drafts/26_1__unskip_tests
branch
from
aa9fab4 to
83c8bc2
Compare
anna-shakhova
force-pushed
the
drafts/26_1__unskip_tests
branch
from
83c8bc2 to
ffb382b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request unskips several DataGrid demo tests that were previously disabled. The PR makes tests active again across multiple frameworks (jQuery, Angular, React, Vue) and updates the theme detection logic in the MultipleRecordSelectionModes demo.
Changes:
- Unskipped two QUnit tests in DataGrid: one for selection behavior and one for remote REST store loading
- Removed 'Toolbar', 'MultipleRecordSelectionModes', and 'RemoteCRUDOperations' from skipped test lists across frameworks
- Updated theme detection logic in MultipleRecordSelectionModes demos to use
isGeneric()instead of string checking - Cleaned up duplicate entries and sorted test skip arrays alphabetically
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/selection.tests.js | Changed QUnit.skip to QUnit.test for selection event test |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/dataGrid.tests.js | Changed QUnit.skip to QUnit.test for REST store test and moved ticket reference to test name |
| apps/demos/utils/visual-tests/matrix-test-helper.ts | Removed 'Toolbar' from skipped tests, removed duplicate 'EditStateManagement' entries, and alphabetically sorted arrays |
| apps/demos/testing/skipped-tests.js | Removed 'Toolbar', 'MultipleRecordSelectionModes', and 'RemoteCRUDOperations' from skipped tests across Angular, React, and Vue |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/Vue/App.vue | Updated theme detection to use isGeneric() function with corrected logic |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/ReactJs/App.js | Updated theme detection to use isGeneric() function with corrected logic |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/React/App.tsx | Updated theme detection to use isGeneric() function with corrected logic |
| apps/demos/Demos/DataGrid/MultipleRecordSelectionModes/Angular/app/app.component.ts | Updated theme detection to use isGeneric() function with corrected logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.