Skip to content

chore(deps): block dirty-chai major updates (requires chai 6)#106

Merged
Alyar666 merged 1 commit into
masterfrom
block-dirty-chai-major
Jun 26, 2026
Merged

chore(deps): block dirty-chai major updates (requires chai 6)#106
Alyar666 merged 1 commit into
masterfrom
block-dirty-chai-major

Conversation

@Alyar666

@Alyar666 Alyar666 commented Jun 26, 2026

Copy link
Copy Markdown

Summary

Renovate keeps proposing a major dirty-chai upgrade (2.x3.x, see #105), but that update cannot work with the current test setup and fails every CI test job.

dirty-chai v3 requires chai 6 (peer dependency chai: '>=6.2.0 <7'), while this project is intentionally pinned to chai v4 (see #103). chai v5+ is ESM-only, so dirty-chai@3 is ESM-only too, and our CommonJS Mocha harness loads it via require:

// spec/config/setup.js
chai.use(require('dirty-chai'));

With dirty-chai@3 the test bootstrap fails before a single test runs (same failure mode as the blocked chai v6 bump):

ERROR [ERR_MODULE_NOT_FOUND]: Cannot find module '.../spec/config/setup'
       imported from .../mocha/lib/nodejs/esm-utils.js

This is exactly the situation #103 anticipated:

the plugins would need work too (dirty-chai requires ^3 for chai 6 ...), so moving to chai 6 is a dedicated ESM migration, not a dependency bump.

This PR disables major dirty-chai updates in Renovate (minor/patch within 2.x stay enabled), mirroring the existing chai and path-to-regexp rules. Once merged, Renovate will stop re-opening the dirty-chai v3 PR, so #105 can be closed.

Copilot AI review requested due to automatic review settings June 26, 2026 11:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables Renovate major updates for dirty-chai because dirty-chai@3 requires chai@6 (ESM-only) while this repo intentionally remains on chai@4 due to a CommonJS Mocha test harness.

Changes:

  • Add a Renovate packageRules entry to block major upgrades of dirty-chai.
  • Document the rationale inline (peer dependency on chai 6 / ESM incompatibility with current test setup).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 1.33 MB

ℹ️ View Unchanged
Filename Size
dist/dx-exceljs-fork.bare.js 393 kB
dist/dx-exceljs-fork.bare.min.js 243 kB
dist/dx-exceljs-fork.js 433 kB
dist/dx-exceljs-fork.min.js 264 kB

compressed-size-action

@Alyar666 Alyar666 force-pushed the block-dirty-chai-major branch from 864eed3 to 49c09f2 Compare June 26, 2026 11:19
@Alyar666 Alyar666 merged commit 89b37fb into master Jun 26, 2026
15 checks passed
@Alyar666 Alyar666 deleted the block-dirty-chai-major branch June 26, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants