chore(deps): block dirty-chai major updates (requires chai 6)#106
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Disables Renovate major updates for dirty-chai because dirty-chai@3 requires chai@6 (ESM-only) while this repo intentionally remains on chai@4 due to a CommonJS Mocha test harness.
Changes:
- Add a Renovate
packageRulesentry to block major upgrades ofdirty-chai. - Document the rationale inline (peer dependency on chai 6 / ESM incompatibility with current test setup).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
864eed3 to
49c09f2
Compare
anna-shakhova
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renovate keeps proposing a major
dirty-chaiupgrade (2.x→3.x, see #105), but that update cannot work with the current test setup and fails every CI test job.dirty-chaiv3 requires chai 6 (peer dependencychai: '>=6.2.0 <7'), while this project is intentionally pinned to chai v4 (see #103). chai v5+ is ESM-only, sodirty-chai@3is ESM-only too, and our CommonJS Mocha harness loads it viarequire:With
dirty-chai@3the test bootstrap fails before a single test runs (same failure mode as the blocked chai v6 bump):This is exactly the situation #103 anticipated:
This PR disables major
dirty-chaiupdates in Renovate (minor/patch within 2.x stay enabled), mirroring the existingchaiandpath-to-regexprules. Once merged, Renovate will stop re-opening the dirty-chai v3 PR, so #105 can be closed.