Fix block math delimiters and workflow path in ecosystem monograph#18
Fix block math delimiters and workflow path in ecosystem monograph#18
Conversation
- Fixed multiple occurrences of block math equation delimiters `$$` that were incorrectly rendered as shell process IDs (e.g., `2240`). - Updated legacy `workflow_path: .github/workflows/dev-log.yml` references to correctly point to `.github/workflows/research-log.yml`. Co-authored-by: Devanik21 <162272415+Devanik21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical formatting and linking issues within the "ecosystem_monograph.md" documentation. The changes ensure that mathematical equations render correctly by fixing corrupted LaTeX delimiters and update outdated internal references to the correct workflow path, thereby improving the overall accuracy and readability of the monograph. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects formatting issues in the ecosystem_monograph.md document. It fixes broken LaTeX math block delimiters that were malformed into process IDs and updates the workflow_path in the frontmatter of numerous log entries to point to the correct research-log.yml file. The changes are corrective and improve the document's rendering and accuracy. I've suggested a minor stylistic improvement to the math blocks for consistency with the rest of the file.
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2240 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2240 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2284 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2284 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2343 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2343 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2470 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2470 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2230 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2230 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2312 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2312 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2245 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2245 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2300 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2300 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
| #### Quantum Fisher Information Matrix (S-Matrix) | ||
| Stochastic Reconfiguration (SR) optimization is verified via the Fubini-Study metric. We ensure the ehBmatrix formation remains non-singular: | ||
| 2322 S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle 2322 | ||
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ |
There was a problem hiding this comment.
For consistency with other math blocks in this file (e.g., on line 68), please remove the spaces inside the $$ delimiters.
| $$ S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle $$ | |
| $$S_{ij} = \langle O_i O_j \rangle - \langle O_i \rangle \langle O_j \rangle$$ |
1 participant
I acted as
Jules-Patroland performed safe, minimal improvements to the repository's documentation as requested.I investigated the codebase to address formatting and linking issues while maintaining maximum restraint.
docs/ecosystem_monograph.md, I discovered that the$$block math delimiters had accidentally been expanded by a bash script into process IDs (e.g.,2240 S_{ij} = ... 2240). I usedsedto precisely revert these malformed identifiers back to proper$$tags across all instances so the equations will render correctly.dev-log.ymlindocs/ecosystem_monograph.mdmetadata blocks to correctly point to the canonicalresearch-log.ymlscript.190) matches the latest state of the README and the most recent monograph log. I left historical log entries (which recorded older counts like257and270) untouched to maintain their integrity. I also preserved existing links likeGalaxy-datsset, following instructions not to break references to external repositories that haven't been officially renamed.The changes are now staged and submitted for review.
PR created automatically by Jules for task 10834984953088128791 started by @Devanik21