Open
Conversation
…time-configurable esbuild.config.ts inlines every key from .env.production into the bundle via 'define'. That's fine for build-time constants, but deployment concurrency and the shutdown drain grace window are operator knobs that must be tunable from docker-compose env / systemd unit / shell without rebuilding. If one of these accidentally ends up in .env.production, its value gets baked in and the runtime env var is silently ignored. Moved the skip list into a named set so the intent is explicit and adding more runtime-only keys later is a one-line change.
Attaching a bare `.then()` to a pending queue-creation promise leaves a dangling chain with no error handler. In the happy path this never fires, but under Node's default strict-throw policy for unhandled rejections a future change to `concurrencyProvider` that lets an exception escape would take the process down on the handler-registration path. Chain a no-op `.catch` so any rejection is absorbed; getOrCreate's own catch has already unregistered the slot so the next enqueue retries cleanly.
Bring the local host in line with the remote-server experience: an operator can tune how many deployments the Dokploy host runs in parallel from Settings -> Web Server, no rebuild or service restart required. - Adds deploymentConcurrency to webServerSettings (default 1) + migration. - settings.updateDeploymentConcurrency tRPC mutation persists the value and pushes it into the live deploymentQueueManager for LOCAL_TARGET on the same tick. - ChangeConcurrencyModal accepts serverId: string | null. String targets the remote path (unchanged); null routes through the new local mutation/query. - queueSetup concurrencyProvider now reads webServerSettings for LOCAL_TARGET (DEPLOYMENT_QUEUE_CONCURRENCY env var stays as the cold-boot default when no row exists yet).
…tOrCreate, trim comments
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci…tConcurrency to test mock
…es + AbortController cancel + killDockerBuild side-channel
…ping, replace killDockerBuild with per-job cancel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploymentConcurrency(default 1, max 10) — limits how many deployments run in parallel per target server. The queue is target-aware so other servers are unaffectedserver.deploymentConcurrencyandwebServerSettings.deploymentConcurrency(bothint, default 1)grouped-queue+queue-router+queue-managerto support per-server worker poolsTest plan
__test__/queues/*)