fix(compose): preserve raw remote mounts#75
Open
AminDhouib wants to merge 2 commits into
Open
Conversation
Use the saved raw compose source during conversion instead of reading a potentially stale remote materialization. Preserve tmpfs declarations and long-syntax volume mounts through preview and stack deployment. Fixes Dokploy#4794 Co-Authored-By: Codex <noreply@openai.com> (cherry picked from commit e43d99e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Dokploy#4795 by @yusoofsh
Addresses Dokploy#4794
What
Preserve raw remote compose mounts. When a compose service uses
sourceType: "raw",addDomainToComposenow parses the saved rawcomposeFiledirectly (yaml.parsewithmaxAliasCount: 10000) instead of reading a potentially stale remote materialization over SSH. This preservestmpfsdeclarations and long-syntax (type: volume/type: tmpfs) volume mounts through preview and stack deployment on remote servers.Files
packages/server/src/utils/docker/domain.ts— add asourceType === "raw"branch ahead of theserverIdremote-load branch.apps/dokploy/__test__/compose/domain/raw-compose.test.ts— new test asserting the raw source is used (execAsyncRemote not called) and mount syntax is preserved.Adaptations
Clean cherry-pick (
git cherry-pick -x e43d99e), no conflicts.yaml.parseis already imported indomain.tsand thesourceTypeComposeenum already includes"raw"on fork canary, so no adaptation was needed.Verification
Clean cherry-pick onto
origin/canary; change verified by inspection. Typecheck/tests run in CI (worktree has no installed node_modules for local runs). No drizzle migrations touched.