fix(ui): resolve unclickable watch path removal button#76
Open
AminDhouib wants to merge 3 commits into
Open
Conversation
(cherry picked from commit ae95485)
…ton a11y - Properly negate FormItem spacing for the 'Enable Submodules' toggle inline layout - Drop redundant focus outline hide and add aria-label for watchpath delete buttons Co-authored-by: Fredy Acuña <fredhiixd@gmail.com> (cherry picked from commit a94f8b9)
Co-Authored-By: Fredy Acuna <57413945+fredhii@users.noreply.github.com> (cherry picked from commit 92c5879)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Dokploy#4782 by @imrja8
Addresses Dokploy#4780
What
Fix the unclickable watch-path removal button. The
<X>lucide icon carried theonClickdirectly, so clicks on the SVG did not reliably remove the watch path. Wrap the icon in a real<button type="button">witharia-label="Remove watch path", and correct the "Enable Submodules" toggle'sFormItemvertical alignment. Applied consistently across all 10 git-provider forms (application + compose: bitbucket / git / gitea / github / gitlab).Files
10 ×
apps/dokploy/components/dashboard/{application,compose}/general/generic/save-*-provider*.tsxAdaptations
Clean cherry-pick of all 3 upstream commits (
git cherry-pick -xofae95485,a94f8b9,92c5879), no conflicts. Co-authorship by @fredhii on commits 2-3 is preserved in the trailers.Sibling merge-order
No file overlap with fork PRs #73 / #74 — those touch webhook backend (
apps/dokploy/pages/api/deploy/*,packages/server/src/utils/watch-paths/*), whereas this PR touches only UI provider forms. No merge-order constraint in either direction.Verification
Clean cherry-pick onto
origin/canary; pure JSX/className change verified by inspection. Typecheck/build run in CI (worktree has no installed node_modules for local runs). No drizzle migrations touched.