Skip to content

Fix "Uninstall package, then update it" failing on WinGet packages #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits into from
Jul 13, 2026
+4 −3
Merged

Fix "Uninstall package, then update it" failing on WinGet packages #5077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b84749
Fix uninstall-then-update/reinstall running the uninstall twice (#5036)
GabrielDuf Jul 13, 2026
1699f54
Install the new version instead of updating in uninstall-then-update …
GabrielDuf Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@
banner.Message = CoreTools.Translate(
"It looks like WinGet is not working properly. Do you want to attempt to repair WinGet?");
banner.ActionButtonText = CoreTools.Translate("Repair WinGet");
banner.ActionButtonCommand = new AsyncRelayCommand(AvaloniaPackageOperationHelper.HandleBrokenWinGetAsync);

Check warning on line 309 in src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs

View workflow job for this annotation

GitHub Actions / Build (linux-x64) 

This call site is reachable on all platforms. 'AvaloniaPackageOperationHelper.HandleBrokenWinGetAsync()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

Check warning on line 309 in src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs

View workflow job for this annotation

GitHub Actions / Build (linux-arm64) 

This call site is reachable on all platforms. 'AvaloniaPackageOperationHelper.HandleBrokenWinGetAsync()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

Check warning on line 309 in src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs

View workflow job for this annotation

GitHub Actions / Build (macos-x64) 

This call site is reachable on all platforms. 'AvaloniaPackageOperationHelper.HandleBrokenWinGetAsync()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

Check warning on line 309 in src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs

View workflow job for this annotation

GitHub Actions / Build (macos-arm64) 

This call site is reachable on all platforms. 'AvaloniaPackageOperationHelper.HandleBrokenWinGetAsync()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

Check warning on line 309 in src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs

View workflow job for this annotation

GitHub Actions / Linux (Avalonia) 

This call site is reachable on all platforms. 'AvaloniaPackageOperationHelper.HandleBrokenWinGetAsync()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

Check warning on line 309 in src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs

View workflow job for this annotation

GitHub Actions / Linux (NativeAOT) 

This call site is reachable on all platforms. 'AvaloniaPackageOperationHelper.HandleBrokenWinGetAsync()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
banner.IsClosable = true;
banner.IsOpen = true;
}
Expand Down Expand Up @@ -381,7 +381,7 @@
reinstallOp.OperationFailed += (_, _) => TelemetryHandler.InstallPackage(package, TEL_OP_RESULT.FAILED, TEL_InstallReferral.ALREADY_INSTALLED);
AvaloniaOperationRegistry.Add(uninstallOp);
AvaloniaOperationRegistry.Add(reinstallOp);
_ = uninstallOp.MainThread();
// uninstallOp runs as reinstallOp's prerequisite; launching it directly too would execute it twice concurrently
_ = reinstallOp.MainThread();
}

Expand Down
5 changes: 3 additions & 2 deletions src/UniGetUI.Avalonia/Views/SoftwarePages/SoftwareUpdatesPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,12 +363,13 @@ private static async Task LaunchUninstallThenUpdate(IPackage? package)
var uninstallOp = new UninstallPackageOperation(package, uninstallOpts);
uninstallOp.OperationSucceeded += (_, _) => TelemetryHandler.UninstallPackage(package, TEL_OP_RESULT.SUCCESS);
uninstallOp.OperationFailed += (_, _) => TelemetryHandler.UninstallPackage(package, TEL_OP_RESULT.FAILED);
var updateOp = new UpdatePackageOperation(package, updateOpts, req: uninstallOp);
// Once uninstalled the package is gone, so the second step must install the new version fresh; a plain update would fail with "no installed package found".
var updateOp = new InstallPackageOperation(package, updateOpts, req: uninstallOp);

@Infinitay infinity (Infinitay) Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're now changing the process to instead install the package, shouldn't we be renaming the menu option to reflect the changes too in order to avoid confusion? For example, changing "Uninstall package, then update it" to "Uninstall package, then install latest".

updateOp.OperationSucceeded += (_, _) => TelemetryHandler.UpdatePackage(package, TEL_OP_RESULT.SUCCESS);
updateOp.OperationFailed += (_, _) => TelemetryHandler.UpdatePackage(package, TEL_OP_RESULT.FAILED);
AvaloniaOperationRegistry.Add(uninstallOp);
AvaloniaOperationRegistry.Add(updateOp);
_ = uninstallOp.MainThread();
// uninstallOp runs as updateOp's prerequisite; launching it directly too would execute it twice concurrently
_ = updateOp.MainThread();
}

Expand Down
Loading