Fix sorting of installed-packages column under NativeAOT#5116
Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits intoJul 16, 2026
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 16, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
fix/datagrid-header-sort-aot-5103
branch
July 16, 2026 17:44
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves sorting functionality for package lists, particularly to ensure compatibility with NativeAOT release builds by avoiding reflection-based sorting. The changes introduce a strongly-typed comparer for both manual and DataGrid column sorting, ensuring consistent and reliable sorting behavior across the UI.
Sorting improvements for package lists:
ApplyToListmethod inPackageCollections.csto use a strongly-typed comparer, ensuring that sorting is consistent and supports semantic version comparison for package versions. This replaces the previous string-based key sorting for version fields.Comparemethod and updatedGetSortKeyto be static and accept a sorter parameter, supporting more flexible and accurate sorting logic.GetColumnComparermethod to provide a reflection-free comparer for DataGrid's native column sorting, supporting AOT-safe builds.UI integration for AOT-safe DataGrid sorting:
AbstractPackagesPage.axaml.csto assign a strongly-typedCustomSortComparerto each sortable DataGrid column, and explicitly setCanUserSortto true, ensuring column header clicks trigger sorting even in NativeAOT builds.General code maintenance:
using System.Collections;directive inPackageCollections.csto support the new comparer implementation.