Skip to content

[fix] /auth/refresh 응답에 hasSession 쿠키 재설정 추가 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nYeonG4001 merged 1 commit into from
Apr 12, 2026
Merged

[fix] /auth/refresh 응답에 hasSession 쿠키 재설정 추가 #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/devpick/domain/user/controller/AuthController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ public ApiResponse<TokenResponse> refresh(
HttpServletResponse response) {
String[] tokens = tokenService.reissueTokens(refreshToken);
setRefreshTokenCookie(response, tokens[1]);
setHasSessionCookie(response);
return ApiResponse.ok(new TokenResponse(tokens[0]));
}

Expand Down
30 changes: 28 additions & 2 deletions src/test/java/com/devpick/domain/user/controller/AuthControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ void logout_userNotFound_returns404() throws Exception {
// ── refresh ──────────────────────────────────────────────

@Test
@DisplayName("POST /auth/refresh - Cookie의 Refresh Token으로 새 accessToken(바디)과 refreshToken(Cookie)을 반환한다")
@DisplayName("POST /auth/refresh - Cookie의 Refresh Token으로 새 accessToken(바디), refreshToken(Cookie), hasSession(Cookie)을 반환한다")
void refresh_success() throws Exception {
given(tokenService.reissueTokens("valid-refresh-token"))
.willReturn(new String[]{"new-access-token", "new-refresh-token"});
Expand All @@ -258,7 +258,26 @@ void refresh_success() throws Exception {
.andExpect(jsonPath("$.data.accessToken").value("new-access-token"))
.andExpect(header().string("Set-Cookie", containsString("HttpOnly")))
.andExpect(header().string("Set-Cookie", containsString("SameSite=None")))
.andExpect(header().string("Set-Cookie", containsString("refreshToken=new-refresh-token")));
.andExpect(header().string("Set-Cookie", containsString("refreshToken=new-refresh-token")))
.andExpect(result -> assertThat(
result.getResponse().getHeaders("Set-Cookie"),
hasItem(allOf(containsString("hasSession=true"), containsString("SameSite=Lax")))));
}

@Test
@DisplayName("POST /auth/refresh - 성공 시 hasSession 쿠키의 maxAge가 refreshToken과 동일하게 갱신된다")
void refresh_success_hasSessionMaxAgeRenewed() throws Exception {
given(tokenService.reissueTokens("valid-refresh-token"))
.willReturn(new String[]{"new-access-token", "new-refresh-token"});

mockMvc.perform(post("/auth/refresh")
.cookie(new Cookie(AuthController.REFRESH_TOKEN_COOKIE, "valid-refresh-token")))
.andExpect(status().isOk())
.andExpect(result -> assertThat(
result.getResponse().getHeaders("Set-Cookie"),
hasItem(allOf(
containsString("hasSession=true"),
containsString("Max-Age=" + AuthController.REFRESH_TOKEN_MAX_AGE)))));
}

@Test
Expand All @@ -273,6 +292,13 @@ void refresh_invalidToken_returns401() throws Exception {
.andExpect(jsonPath("$.success").value(false));
}

@Test
@DisplayName("POST /auth/refresh - refreshToken 쿠키가 없으면 401을 반환한다")
void refresh_missingCookie_returns401() throws Exception {
mockMvc.perform(post("/auth/refresh"))
.andExpect(status().isUnauthorized());
}

// ── email/send & email/verify ──────────────────────────────────────────────

@Test
Expand Down
Loading