Open
Conversation
DevreeseJorik
requested changes
Mar 2, 2023
Owner
DevreeseJorik
left a comment
There was a problem hiding this comment.
Would you mind also adding these checks for the Memory:write and GetByteRange methods? I can also do it myself. We can merge it once that's done.
Contributor
Author
|
Okay, I'll do it. |
Contributor
Author
|
I Added boundary checks to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing memory out of range, such as during a game restart, can fill the lua console with error messages and slow down the frame rate.
To avoid this I added a check of the address in advance before reading the memory.