Skip to content

feat: Safe Max button with configurable HF floor (#6)#211

Open
Escelit wants to merge 1 commit into
Dgetsylver:mainfrom
Escelit:feat/safe-max-button
Open

feat: Safe Max button with configurable HF floor (#6)#211
Escelit wants to merge 1 commit into
Dgetsylver:mainfrom
Escelit:feat/safe-max-button

Conversation

@Escelit

@Escelit Escelit commented May 30, 2026

Copy link
Copy Markdown
Contributor

Summary

One-click Safe Max button that snaps the leverage slider to the highest
value where projected HF ≥ a user-configured floor.

Changes

  • Safe Max button added inline next to the leverage slider; walks down
    from slider max in 0.1× steps and picks the highest leverage where
    hfForLeverage >= floor
  • HF floor input added to settings dropdown (default 1.2, min 1.01)
  • Floor persisted in localStorage under key safeMaxHfFloor

Acceptance criteria

  • Clicking Safe Max snaps slider to max leverage where projected HF >= floor
  • Floor is editable in settings menu and persists across reloads

Closes #6

- Add Safe Max button next to leverage slider; snaps to highest
  leverage where projected HF >= user-configured floor
- Add HF floor input in settings dropdown (default 1.2, min 1.01)
- Persist floor value in localStorage under safeMaxHfFloor key
@drips-wave

drips-wave Bot commented May 30, 2026

Copy link
Copy Markdown

@Escelit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Dgetsylver

Copy link
Copy Markdown
Owner

Logic is sound and it's the only PR in the batch with a passing parity check, but it's now conflicting with main after #214 touched main.ts — please rebase. One edge case while you're in there: when no leverage satisfies the HF floor, best = 1.0 is written to a slider whose min is 1.1, so the number input shows an out-of-range value — clamp to slider min or surface a warning instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A4: "Safe Max" button

2 participants