ci: build and test Soroban contracts on every PR#237
Merged
Conversation
No workflow currently builds or tests the contracts: parity.yml only builds the rate_calc binary + frontend tests, and blend_leverage is not a cargo workspace member so 'cargo test --workspace' never touches it. This let dev land non-compiling contract code (#157/#217) and let PRs like #233 (deposit traps at runtime) and #235 (proptests don't compile) through with zero contract verification. Adds contracts.yml: cargo test + wasm32v1-none release build for blend_leverage on any PR touching contracts/**. Clippy -D warnings is left as a TODO until the crate's existing digit-grouping lint debt is paid down (would otherwise red every PR immediately).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
No workflow builds or tests the contracts:
parity.ymlonly buildsrate_calc+ frontend tests, andblend_leverageis not a cargo workspace member socargo test --workspacenever touches it. This let dev land non-compiling contract code (#157/#217) and let PRs like #233 (deposit traps at runtime) and #235 (proptests don't compile) through with zero contract verification.What
Adds
.github/workflows/contracts.yml:cargo test+wasm32v1-nonerelease build forblend_leverageon any PR touchingcontracts/**. Clippy-D warningsis left as a TODO until the crate's existing digit-grouping lint debt is paid down (would otherwise red every PR immediately).Verification
On current main:
cargo test43/43 pass, wasm release build passes.🤖 Generated with Claude Code