feat(swap): add curated asset picker and custom slippage#325
Open
Babigdk wants to merge 1 commit into
Open
Conversation
|
@Babigdk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the hardcoded swap asset universe with the LOBSTR curated assets feed and add support for custom slippage values.
Changes Made
frontend/src/views/swapAssets.tsto load, cache, and normalize assets from the LOBSTR curated assets feed.SWAP_ASSETSandBROKER_TO_CONTRACTmappings with dynamically loaded asset metadata.0.1%,0.5%, and1.0%presets.0 < value <= 50).5%.Related Issue
Closes #318
Checks
Notes for Reviewers
Verification Performed
Remaining Follow-up
This PR implements the curated asset data layer and custom slippage support. The searchable asset picker with token logos may be completed in a follow-up change if additional UI work is required beyond the scope of the current implementation.
Suggested Validation
Manual Testing
0.4,2.4,100, negative values, values greater than505%