Fix highlight inset not taking effect#79
Merged
Dherse merged 3 commits intoDherse:mainfrom Apr 10, 2025
Merged
Conversation
Owner
|
Ugh what a stupid bug, thanks a lot! I need to do a double check over all of the states that they're correct eventually 😭 |
Owner
|
Thank you very much! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was accidentally typoed in 32c4233 which moved it. This made it impossible to disable highlight-inset, and use highlight-outset instead.
I have updated the test to make it more obvious what it is testing

Feel free to not take the whitespace clean commit -- my editor does it automatically and it's easiest to throw away (and review) if I do it in a separate commit (and if it's the first, it means I can edit later and then will only throw it away as the last thing).