Add generics to Constructor#5
Merged
Merged
Conversation
This allows static analysis to deduce the type of the service that will be created from a `Constructor` definition.
mecha
previously approved these changes
Apr 10, 2021
I guess, in `class-string<T>`, `T` must be of type `object`. See vimeo/psalm#3933.
I guess, in `class-string<T>`, `T` must be of type `object`. See vimeo/psalm#3933.
This corresponds to the minimal requirement.
Maintaining config compatibility is hard otherwise.
It is necessary for PHP 8.4+.
This is a library. It doesn't use its own methods. See vimeo/psalm#11320 in relation to attribute.
mecha
previously approved these changes
Nov 21, 2025
Is now like a real builder.
Is now stringable. Less methods to call, less chars to type.
The Psalm one isn't quite fixed yet, though: https://youtrack.jetbrains.com/issue/WI-83525/Psalm-Settings-Not-Saving
1. Now allows controlling whether uniqueness includes autoloaded space. 2. If `extends` is configured, it will be used as the class prefix. This helps identify this class during debugging.
Package Update
This allows static analysis to deduce the type of the service that will be created from a `Constructor` definition.
I guess, in `class-string<T>`, `T` must be of type `object`. See vimeo/psalm#3933.
…task/constructor-generics # Conflicts: # composer.lock # src/Factories/Constructor.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows static analysis to deduce the type of the service
that will be created from a
Constructordefinition.