Made digital specimen cards more specific and according to their UI#258
Draft
MelanieTheLion wants to merge 3 commits into
Draft
Made digital specimen cards more specific and according to their UI#258MelanieTheLion wants to merge 3 commits into
MelanieTheLion wants to merge 3 commits into
Conversation
|
❌ The last analysis has failed. |
|
MelanieTheLion
commented
Jul 2, 2026
MelanieTheLion
commented
Jul 2, 2026
MelanieTheLion
commented
Jul 2, 2026
MelanieTheLion
commented
Jul 2, 2026
| import { CopyIcon } from '@radix-ui/react-icons'; | ||
|
|
||
| interface Props { | ||
| fragment: any; |
MelanieTheLion
commented
Jul 2, 2026
| fragment: any; | ||
| } | ||
|
|
||
| export const CitationLicenseCard = ({ fragment }: Props ) => { |
MelanieTheLion
commented
Jul 2, 2026
| fragment: any; | ||
| } | ||
|
|
||
| export const CitationLicenseCard = ({ fragment }: Props ) => { |
Collaborator
Author
There was a problem hiding this comment.
Also, this one is not done yet
MelanieTheLion
commented
Jul 2, 2026
| <CopyIcon /> | ||
| </Button> | ||
| </div> | ||
| <div className="ds-card-citation"> |
Collaborator
Author
There was a problem hiding this comment.
Choose between ds and digital-specimen as class names
MelanieTheLion
commented
Jul 2, 2026
| <p>{craftCitation(fragment)}</p> | ||
| </div> | ||
| <div className="digital-specimen-card-content"> | ||
| <LabelValuePair item={fragment['license']}></LabelValuePair> |
Collaborator
Author
There was a problem hiding this comment.
License needs to be url
MelanieTheLion
commented
Jul 2, 2026
|
|
||
| .taxonomic-status { | ||
| a { | ||
| margin-inline-end: 8px; |
Collaborator
Author
There was a problem hiding this comment.
variable pls
MelanieTheLion
commented
Jul 2, 2026
| hidden: boolean; | ||
| } | ||
| }, | ||
| extraItem?: { |
Collaborator
Author
There was a problem hiding this comment.
Is this the way to go here?
MelanieTheLion
commented
Jul 2, 2026
| <span className="property-label verbatim">{item.label}</span> | ||
| : <span className="property-label">{item.label}</span> | ||
| } | ||
| <span className={"property-label " + (item.type === 'verbatim' ? "verbatim" : "")}>{item.label}</span> |
Collaborator
Author
There was a problem hiding this comment.
This can be differently formatted
MelanieTheLion
commented
Jul 2, 2026
| }, | ||
| virtualCollection: { | ||
| label: 'In Virtual Collection(s)', | ||
| resolve: (_) => 'Unknown' |
Collaborator
Author
There was a problem hiding this comment.
Check with Martijn what to do here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
The DigitalSpecimenCard was first a reusable component for all 5 dataCards. But I ran into issues that made the reusable component become way too complicated. So I decided to separate concerns and create separate components for each data card. More code and more components, but easier to maintain in the long run.
UI still needs tweaks, but I have outstanding questions I have to solve first.
This page is not officially live yet. Because it is so big, we are working in iterations.
UX Design
Not in this pr:
What it looks like now:
