Skip to content

[Unit Tests] Add tests for WindowBoundary, PlayerStatModifier, and ability attributes#306

Open
DiamondDagger590 wants to merge 1 commit into
recodefrom
claude/magical-cray-4om959
Open

[Unit Tests] Add tests for WindowBoundary, PlayerStatModifier, and ability attributes#306
DiamondDagger590 wants to merge 1 commit into
recodefrom
claude/magical-cray-4om959

Conversation

@DiamondDagger590

Copy link
Copy Markdown
Owner

Summary

  • Add 12 tests for WindowBoundary.Fixed and WindowBoundary.Recurring record types covering datetime resolution, year offset behavior, timezone handling, and accessor methods
  • Add 9 tests for PlayerStatModifier covering constructor/getters (including zero and negative values), tick no-op behavior, and never-expires semantics
  • Add 47 tests to SpecializedAbilityAttributeCoverageTest for four previously untested ability attribute types:
    • AbilityTierAttribute (14 tests): default/value constructors, shouldContentBeSaved logic, create factory, convertContent, displayable content, serialization
    • AbilityUnlockedAttribute (11 tests): default/value constructors, shouldContentBeSaved for true/false, create factory, convertContent, serialization
    • AbilityCooldownAttribute (11 tests): default/value constructors, shouldContentBeSaved for 0/past/future timestamps, create factory, convertContent, serialization
    • AbilityToggledOffAttribute (11 tests): default/value constructors, shouldContentBeSaved, create factory, convertContent, display priority, GuiModifiableAttribute check, serialization

Total: 68 new tests

Test plan

  • All 68 new tests pass in isolation
  • Full test suite passes (4948 tests, 6 pre-existing failures in QuestRewardDistributionResolverPotBehaviorTest unrelated to these changes)
  • No regressions introduced

🤖 Generated with Claude Code

https://claude.ai/code/session_01NDoUhtmt3RuBLJrcm4n5pg


Generated by Claude Code

…ility attributes

Cover WindowBoundary.Fixed and WindowBoundary.Recurring (12 tests),
PlayerStatModifier constructor/tick/expiry (9 tests), and four
ability attribute types: AbilityTierAttribute, AbilityUnlockedAttribute,
AbilityCooldownAttribute, AbilityToggledOffAttribute (47 tests) in the
existing SpecializedAbilityAttributeCoverageTest.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NDoUhtmt3RuBLJrcm4n5pg
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DiamondDagger590, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 28f01e7c-3184-4220-ad51-6df208c29f90

📥 Commits

Reviewing files that changed from the base of the PR and between 6cd90a4 and 4c5dc9d.

📒 Files selected for processing (3)
  • src/test/java/us/eunoians/mcrpg/ability/attribute/SpecializedAbilityAttributeCoverageTest.java
  • src/test/java/us/eunoians/mcrpg/quest/chain/availability/WindowBoundaryTest.java
  • src/test/java/us/eunoians/mcrpg/stat/instance/PlayerStatModifierTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/magical-cray-4om959

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants