Skip to content

LIMS-2059: Re-enable reprocess button after any parameter change#1031

Open
ndg63276 wants to merge 1 commit intomasterfrom
improvement/LIMS-2059/re-enable-reprocess-button-quicker
Open

LIMS-2059: Re-enable reprocess button after any parameter change#1031
ndg63276 wants to merge 1 commit intomasterfrom
improvement/LIMS-2059/re-enable-reprocess-button-quicker

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Feb 6, 2026

JIRA ticket: LIMS-2059

Summary:

#1009 introduced a 5s delay after pushing the reprocessing 'submit' button, to prevent accidental double clicks. This seems very long if you want to submit multiple similar jobs, so the button should re-enable if you change something.

Changes:

  • Make re-enabling the button it's own function
  • Trigger that function after 5s or if any input or select elements are changed
  • Do this for normal reprocessing, downstream reprocessing or multicrystal reprocessing

To test:

  • Use the live database as otherwise the reprocessing jobs will not exist as zocalo expects and may cause problems. Alternatively, comment out the _enqueue functions in these files.
  • Go to a data collection with some automatic processing, eg /dc/visit/mx23694-154/id/21536724
  • Click the small cog item to open the "Reprocess Data" window
  • Click Integrate, and check the Integrate button is disabled for 5s
  • Click Integrate again, and then change a parameter, eg the pipeline or the high res limit, the Integrate button should be enabled again
  • Close that window and view an existing Autoprocessing job. Click the "Downstream Processing" button, and then repeat the above tests with the "Submit" button
  • Go to the multicrystal reprocessing page /mc/visit/mx23694-154, and click the crossed arrows next to a data collection to select it. Repeat the above tests with the "Integrate" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant