Closed
Conversation
Collaborator
Author
|
After discussion with James and Karl, the conclusion was to wait for some new API endpoints, so converting to draft for now. |
Collaborator
Author
|
After further thought, this is not the place to put new API functionality. I've done a little tidying, happy for this to be initially disabled by not setting the csv_profile parameter. |
Collaborator
|
Is this still relevant now that we have a CSV uploader page elsewhere? |
Collaborator
Author
|
It's a shame, I would have liked to have this 5-10 years ago, but probably not worth it now. Maybe Synchweb could work with Expeye at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1188
Summary:
The current Diamond CSV importer requires SSH or NX access to Diamond, followed by a special Bash script. Authentication then relies on putting the file in a particular location within a visit.
This importer is web-based, so can be done without SSH or NX, and uses the ISPyB authorisation to check your proposal.
The original code is from #239, but with a bunch of changes to make it work for Diamond. (IMCA csv files do seem to still work, although it no longer creates proteins that don't exist.) Different sites can create different CSV 'formats'.
Changes:
To test: