Skip to content

I15-1: Add read only PV fields#33

Merged
noemifrisina merged 42 commits into
mainfrom
30-31_pvws-and-component
May 8, 2026
Merged

I15-1: Add read only PV fields#33
noemifrisina merged 42 commits into
mainfrom
30-31_pvws-and-component

Conversation

@noemifrisina
Copy link
Copy Markdown
Collaborator

@noemifrisina noemifrisina commented Mar 27, 2026

  • Add a package with utilities to interact with cs-web-lib
  • Use the components in i15-1 to some some read only values

@noemifrisina noemifrisina marked this pull request as ready for review April 24, 2026 10:08
Copy link
Copy Markdown
Contributor

@EmsArnold EmsArnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just two comments, and it may be good to test on the beamline to ensure we're getting the PVs through if that hasn't been done yet.

Could: add a handler for mocking the new subscription, something like this should work:

import { http, HttpResponse, ws } from "msw";

...

const chat = ws.link("wss://pvws.diamond.ac.uk/pvws/pv");

export const handlers = [

  ...

  chat.addEventListener("connection", () => {
    console.log("WebSocket client connecting...");
  }),
];

Nit: when deployed locally, the Diamond logo is very small for me - but only for i15-1, and not for ViSR. I couldn't find any obvious reason for this.

@noemifrisina
Copy link
Copy Markdown
Collaborator Author

Could: add a handler for mocking the new subscription, something like this should work

Good spot, thanks. I'm afraid I completely forgot to do this, will add now!

On the diamond logo, yeah took a look and I have the same. Only thing I can think of is that I had to update some dependencies in the i15-1 package, sci-react-ui among them I believe (which is where we're getting the theme from) - looking into it

@noemifrisina
Copy link
Copy Markdown
Collaborator Author

The annoying bit when adding the handler to msw is that the pv boxes now read not connected by default even when running on a dls workstation

@noemifrisina
Copy link
Copy Markdown
Collaborator Author

The logo was fixed by slightly refactoring the Navbar

@noemifrisina noemifrisina merged commit ae7c4da into main May 8, 2026
2 checks passed
@noemifrisina noemifrisina deleted the 30-31_pvws-and-component branch May 8, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants