base p99#39
Conversation
|
@douglaswinter I believe the P99 app is ready. I’ve built the UI using Visr as a foundation. Please checkI have made changes to the CI Coverage as the new project is not on the main branch and was breaking the CI build. |
douglaswinter
left a comment
There was a problem hiding this comment.
Some top-level comments:
-
We want to minimise duplication. Remove the stuff you don't need e.g. tomography and all related artefacts in /public. If you want PlanBrowser, let's break that out into a package that both visr and p99 apps can import. It's important to tackle this now before the repository grows rapidly. I appreciate you generated from ViSR, but next you should basically remove everything that's not app scaffolding. Eventually we'll have a minimal generator so you don't copy all this stuff that you then need to delete (see issue #9 ).
-
Although I appreciate the inventiveness, I wouldn't merge any easter eggs. Part of the purpose of this repository is discoverability. This app will become an example for apps to come, so we want to increase signal to noise ratio.
-
This one is more for information. We are working on a design system which will take care of low level design aspects such as colour, as well as providing standard components and patterns e.g. layout, navigation. The idea is consistency for the users and lower maintainance burden on devs. You should rarely have to specify colour as in your Dashboard.tsx, which doesn't look right in dark mode - the theme will take care of that for you (I was told the updated one should be merged into scireactui later this week). The general layout of a page will look more like this: https://www.figma.com/proto/bWGBDTZ9e5Ui2tQqD67lHd/Waffle-I15-1-Mail-in-experiments?node-id=3125-31205&starting-point-node-id=3052%3A36336 wth the implementation being worked as part of the waffle sprints currently underway.
|
I have strip every back to bare minimin now, it is now very close to what #9. I will add Blueapi, workflow, one at a time at a later stage? |
douglaswinter
left a comment
There was a problem hiding this comment.
Looks good. Final request, to clean up dependencies. You can leave some if you like as you'd have to add them at some point, but hopefully not all of them!
Part of sm-bluesky315, this PR added a bare-bone landing page for the p99 application.
It is a copy of visr with some mirror changes
Changes:
package.jsonexistence on main branch before running coverage, preventingno package founderrors