Skip to content

base p99#39

Merged
Relm-Arrowny merged 16 commits into
DiamondLightSource:mainfrom
Relm-Arrowny:p99
May 8, 2026
Merged

base p99#39
Relm-Arrowny merged 16 commits into
DiamondLightSource:mainfrom
Relm-Arrowny:p99

Conversation

@Relm-Arrowny
Copy link
Copy Markdown
Collaborator

@Relm-Arrowny Relm-Arrowny commented May 5, 2026

Part of sm-bluesky315, this PR added a bare-bone landing page for the p99 application.
It is a copy of visr with some mirror changes

Changes:

  • Fix CI coverage workflow to handle new packages by checking for package.json existence on main branch before running coverage, preventingno package founderrors
  • Corrected: Names and sessions.
image

@Relm-Arrowny
Copy link
Copy Markdown
Collaborator Author

@douglaswinter I believe the P99 app is ready. I’ve built the UI using Visr as a foundation.

Please check

I have made changes to the CI Coverage as the new project is not on the main branch and was breaking the CI build.

Copy link
Copy Markdown
Collaborator

@douglaswinter douglaswinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some top-level comments:

  1. We want to minimise duplication. Remove the stuff you don't need e.g. tomography and all related artefacts in /public. If you want PlanBrowser, let's break that out into a package that both visr and p99 apps can import. It's important to tackle this now before the repository grows rapidly. I appreciate you generated from ViSR, but next you should basically remove everything that's not app scaffolding. Eventually we'll have a minimal generator so you don't copy all this stuff that you then need to delete (see issue #9 ).

  2. Although I appreciate the inventiveness, I wouldn't merge any easter eggs. Part of the purpose of this repository is discoverability. This app will become an example for apps to come, so we want to increase signal to noise ratio.

  3. This one is more for information. We are working on a design system which will take care of low level design aspects such as colour, as well as providing standard components and patterns e.g. layout, navigation. The idea is consistency for the users and lower maintainance burden on devs. You should rarely have to specify colour as in your Dashboard.tsx, which doesn't look right in dark mode - the theme will take care of that for you (I was told the updated one should be merged into scireactui later this week). The general layout of a page will look more like this: https://www.figma.com/proto/bWGBDTZ9e5Ui2tQqD67lHd/Waffle-I15-1-Mail-in-experiments?node-id=3125-31205&starting-point-node-id=3052%3A36336 wth the implementation being worked as part of the waffle sprints currently underway.

Comment thread apps/p99/helm/values.yaml Outdated
Comment thread apps/p99/public/test-data/seal.png Outdated
Comment thread apps/p99/public/test-data/volume.json Outdated
Comment thread apps/p99/public/test-data/volume.raw Outdated
Comment thread apps/p99/helm/values.yaml Outdated
Comment thread apps/p99/README.md
Comment thread apps/p99/src/utils/workflow.ts Outdated
Comment thread apps/p99/src/mocks/workflows-response.json Outdated
Comment thread apps/p99/src/mocks/handlers.ts Outdated
Comment thread apps/p99/src/components/PlanBrowser/PlanBrowser.test.tsx Outdated
@Relm-Arrowny
Copy link
Copy Markdown
Collaborator Author

I have strip every back to bare minimin now, it is now very close to what #9. I will add Blueapi, workflow, one at a time at a later stage?

@Relm-Arrowny Relm-Arrowny requested a review from douglaswinter May 8, 2026 09:24
Copy link
Copy Markdown
Collaborator

@douglaswinter douglaswinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Final request, to clean up dependencies. You can leave some if you like as you'd have to add them at some point, but hopefully not all of them!

Comment thread apps/p99/package.json
@Relm-Arrowny Relm-Arrowny requested a review from douglaswinter May 8, 2026 12:20
@Relm-Arrowny Relm-Arrowny merged commit d58a478 into DiamondLightSource:main May 8, 2026
2 checks passed
@Relm-Arrowny Relm-Arrowny deleted the p99 branch May 8, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Atlas: Define the p99 application in [atlas]

2 participants