Fix coverage job for new projects#40
Merged
Merged
Conversation
The existing job does the following: 1. Figure out which projects are affected since BASE 2. At HEAD, run coverage for those projects and save report 3. At BASE, run coverage on the same projects and save report 4. Give both outputs to comparison script But for new projects, step 3 will fail because those projects do not exist yet. In this change we filter out affected projects not in the workspace be- fore step 3.
douglaswinter
force-pushed
the
dw/fix_coverage_ci_for_new_projects
branch
from
e2ab863 to
0e8fee6
Compare
Relm-Arrowny
approved these changes
May 8, 2026
Collaborator
Relm-Arrowny
left a comment
Relm-Arrowny
left a comment
There was a problem hiding this comment.
look good to me, it much nicer than my hack to hardcore the folder name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing job does the following:
But for new projects, step 3 will fail because those projects do not exist yet.
In this change we filter out affected projects not in the workspace before step 3.